Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppiumElementLocator & Implicit Waits #735

Closed
titusfortner opened this issue Sep 25, 2017 · 2 comments
Closed

AppiumElementLocator & Implicit Waits #735

titusfortner opened this issue Sep 25, 2017 · 2 comments

Comments

@titusfortner
Copy link
Contributor

Am I reading this code correctly, that every single element location in the Java bindings makes multiple implicit wait wire calls?

When running a test on a remote platform this causes a huge amount of overhead, exacerbated by any increased latency from a proxy, etc during any given run. Implicit waits are heavily discouraged by the Selenium developers (including the guy who created them in the first place). I think it should be relatively easy to change this code to be implemented by an explicit wait strategy, which would only make additional wire calls if they are actually needed.

Are there any other reasons that I'm not aware of that make implicit waits necessary, or can someone pair with me on a PR for this?

@jlipps
Copy link
Member

jlipps commented Sep 26, 2017

Yeah, seems weird for a client to make so many implicit wait calls. Could lead to a performance degradation, especially when there's latency on the wire.

@TikhomirovSergey
Copy link
Contributor

@titusfortner @jlipps the new build is going to be published today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants