feat: Make the coordinates of the screen point configurable #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
reviewed
Sep 10, 2019
| NSCharacterSet.whitespaceAndNewlineCharacterSet]; | ||
| NSString *strY = [screenPointCoords.lastObject stringByTrimmingCharactersInSet: | ||
| NSCharacterSet.whitespaceAndNewlineCharacterSet]; | ||
| if (0 == strX.length || 0 == strY.length) { |
There was a problem hiding this comment.
What about returning an error if the X/Y is greater than screen size with a message like 'the x/y must be less than screen size', too?
There was a problem hiding this comment.
I don't want to control it so much. The coordinates might become valid if screen resolution is changed, for example. Or an external display is connected.
KazuCocoa
approved these changes
Sep 11, 2019
KazuCocoa
approved these changes
Sep 11, 2019
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcoded values were never a good approach. With this PR the screen point is going to be configurable via settings