Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wide and wide_intrinsics to the default assets list #43

Closed
wants to merge 1 commit into from
Closed

Add wide and wide_intrinsics to the default assets list #43

wants to merge 1 commit into from

Conversation

cy94
Copy link

@cy94 cy94 commented Sep 21, 2022

  • wide and wide_intrinsics are missing from the default assets list, hence they are not downloaded when downloading the raw datasets. Added these to the list

Copy link
Contributor

@arik1089 arik1089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Please see the attached comment.

@@ -30,7 +30,7 @@ def raw_files(video_id, assets, metadata):
continue # highres_depth asset only available for video ids from upsampling dataset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle the wide and wide_intrinsics assets in this case as well.
These 2 assets are only available for videos that are part of the upsampling dataset, so the download script should skip downloading them with a warning in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants