Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction timeouts use memory after transaction is destroyed #2335

Closed
ajbeamon opened this issue Nov 8, 2019 · 1 comment
Closed

Transaction timeouts use memory after transaction is destroyed #2335

ajbeamon opened this issue Nov 8, 2019 · 1 comment
Assignees
Milestone

Comments

@ajbeamon
Copy link
Contributor

ajbeamon commented Nov 8, 2019

Transaction timeouts create delay tasks for the run loop that persist for the entire duration of the timeout, regardless of whether the transaction that created them has been destroyed. This could potentially be a concern in cases where the timeout is set to be very long.

I haven't done a full accounting of the memory, though I think that there are 128 bytes used in 64-byte fast allocated chunks plus some other memory that's not being fast allocated.

@etschannen
Copy link
Contributor

Use repeated small delays so that the timeouts will be cleaned up faster after being cancelled.

Audit long delays used generally in the core to determine if this is an issue anywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants