Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export / Import JSON Schema from/to PKL classes #92

Open
buremba opened this issue Feb 8, 2024 · 6 comments
Open

Export / Import JSON Schema from/to PKL classes #92

buremba opened this issue Feb 8, 2024 · 6 comments

Comments

@buremba
Copy link

buremba commented Feb 8, 2024

It would be nice to generate PKL classes from JSON Schema definitions. Similarly, it can go the other way around from PKL to JSON Schema. I'm aware that the typing will be lost, but since JSON Schema is integrated pretty much everywhere, it can provide interoperability for the language.

@buremba buremba changed the title Export / Import JSON Schema to PKL classes Export / Import JSON Schema from/to PKL classes Feb 8, 2024
@bioball
Copy link
Contributor

bioball commented Feb 8, 2024

Good timing; we just submitted apple/pkl-pantry#12 that adds support for this!

@bioball
Copy link
Contributor

bioball commented Feb 9, 2024

That PR has landed.

You can generate Pkl schema from JSON Schema; for example:

pkl eval package://pkg.pkl-lang.org/pkl-pantry/org.json_schema.contrib@1.0.0#/generate.pkl -m . -p source="https://json.schemastore.org/github-action.json"

Note: depending on the input JSON Schema, you might need to tinker with the generated result to make it more useful. Some of JSON Schema is more expressive than Pkl; take a look at the docs for more details: https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-pantry/org.json_schema.contrib/current/generate/index.html

@buremba
Copy link
Author

buremba commented Feb 11, 2024

Great to hear! JSON Schema also conditional blocks i.e if/else and I assume that it's not supported yet. Not sure if it's feasible in addition to the work for anyOf/allOff but maybe something to consider.
BTW, the speed you ship the integrations today is impressive. This was something that I tried with Jsonnet a while and I couldn't manage to get it done in a seamless way. Great work!

@gobetti
Copy link

gobetti commented Mar 5, 2024

generate.pkl works great and was absolutely critical for our team to start considering pkl adoption, thank you for that 👏

I see apple/pkl-pantry#12 mentions it:

provides support for generating JSON Schema from Pkl

but I'm wondering if one is actually able to convert Pkl classes into a JSON Schema; for example:

  1. use generate.pkl to generate Pkl from a JSON Schema
  2. now de-transform the generated Pkl code back into a JSON Schema

I'm describing the scenario above just to be clear about what kind of Pkl code I'm trying to convert to a JSON Schema, in general I don't expect people to do those exact 2 steps. But something like those steps would be helpful for our project to confidently migrate from JSON Schemas to Pkl, and not have to change all the systems to Pkl at once.

Thank you!

@dig
Copy link

dig commented Jun 4, 2024

Allowing conversion of Pkl to JSON Schema would be useful!

@bioball
Copy link
Contributor

bioball commented Jun 4, 2024

We don't get have a Pkl -> JSON Schema generator, but we do have one for OpenAPI v3.1 Schema, which is mostly compatible with JSON Schema.

See the details here: https://pkl-lang.org/package-docs/pkg.pkl-lang.org/pkl-pantry/org.openapis.v3.contrib/current/SchemaGenerator/index.html#generate%28%29

For example, given:

// personSchema.pkl
import "package://pkg.pkl-lang.org/pkl-pantry/org.openapis.v3.contrib@1.0.3#/SchemaGenerator.pkl"

class Person {
  /// The person's legal name.
  name: String?
}

output = SchemaGenerator.generate(Person).output

The command pkl eval personSchema.pkl produces:

{
  "type": "object",
  "title": "Person",
  "properties": {
    "name": {
      "type": "string",
      "description": "The person's legal name.",
      "nullable": true
    }
  },
  "additionalProperties": false
}

There's a couple limitations here; see the details in pkldoc for method generate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants