Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for SignalOffloader methods throwing when used from operators #199

Open
Scottmitch opened this issue Dec 1, 2018 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Scottmitch
Copy link
Member

[1] For methods that account for EnqueueForOffloadingFailed they should also be accounting for more general exceptions that maybe thrown. For example an exception is thrown if the offloader has already be terminated.
[2] For methods that don't account for EnqueueForOffloadingFailed we need to analyze the callers of the offload methods and make sure they propagate exceptions accordingly. For example in the case of ResumeCompletable we invoke this method from onError which means we likely won't propagate the exception in an orderly fashion if this method throws.

[1] #192 (comment)
[2] #192 (comment)

@NiteshKant NiteshKant added the bug Something isn't working label Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants