Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move CompletableProcessor and SingleProcessor out of concurrent.api #325

Closed
Scottmitch opened this issue Feb 19, 2019 · 1 comment
Closed

Comments

@Scottmitch
Copy link
Member

CompletableProcessor and SingleProcessor both currently live in concurrent.api due to usage patterns and convenience. However these classes are not strictly part of the public API and would be more appropriately placed in an internal package somewhere.

CompletableProcessor currently extends concurrent.api.Completable because it is used in concurrent.api and composed over and/or directly returned as a concurrent.api.Completable. After some concurrent reshuffling (#316, removal of subscribe, clarify concurrent classes from concurrent.api, etc...) we should explore converting this from the "base class" to the api variant as needed to decouple from the concurrent.api package.

@jayv
Copy link
Contributor

jayv commented Oct 9, 2019

Done #440

@jayv jayv closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants