swift: remove Windows special case in Block.swift
#599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
CC: @rokhinip |
rokhinip
approved these changes
Mar 23, 2022
|
@swift-ci please test |
|
@swift-ci please test |
|
Any updates on this @compnerd |
|
Thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISPATCH_ENUMwill use a typed enum which creates a typedef to anelaborated type. This fails to be imported into Swift as a numeric
type. Explicitly convert the
numericCast'ed value from the SwiftOptionSetto thedispatch_block_flags_tas a portable alternatespelling. This allows us to continue to import the enum as a typed
value.
Thanks to @beccadax for the pointer that this pattern may not work on
Darwin (which it does not!) and the suggestion for the explicit type
conversion!