Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid plugin build warnings in addTargetDependencies on Linux #83

Closed
ktoso opened this issue Jun 13, 2024 · 2 comments
Closed

Avoid plugin build warnings in addTargetDependencies on Linux #83

ktoso opened this issue Jun 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@ktoso
Copy link
Member

ktoso commented Jun 13, 2024

We're seeing the following warnings when using the plugin on Linux:

13:02:05 /tmp/.check-api_EHIjZG/repo/.build/x86_64-unknown-linux-gnu/apidiff/d16e216341cd13c4f72bf53164dd39acbf14ebbd-checkout/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Preview/Symbolic Links/SharedPackagePluginExtensions/PackageExtensions.swift:31:17: warning: switch covers known cases, but 'TargetDependency' may have additional unknown values
13:02:05                 switch dependency {
13:02:05                 ^
13:02:05 /tmp/.check-api_EHIjZG/repo/.build/x86_64-unknown-linux-gnu/apidiff/d16e216341cd13c4f72bf53164dd39acbf14ebbd-checkout/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Preview/Symbolic Links/SharedPackagePluginExtensions/PackageExtensions.swift:31:17: note: handle unknown values using "@unknown default"
13:02:05                 switch dependency {
13:02:05                 ^

And the respective source is https://github.com/apple/swift-docc-plugin/blob/main/Plugins/SharedPackagePluginExtensions/PackageExtensions.swift#L36-L40

                #if os(macOS) || os(iOS) || os(tvOS) || os(watchOS)
                @unknown default:
                    return
                #endif

Why is this handling only apple platforms - can this be removed so we avoid warning on Linux builds?

@ktoso ktoso added the bug Something isn't working label Jun 13, 2024
@diegolavalledev
Copy link

Looks like it was addressed by #67

@ktoso
Copy link
Member Author

ktoso commented Jun 27, 2024

Seems so! Thanks for the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants