Fix a few minor warnings #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-kusters
approved these changes
Jan 5, 2023
d-ronnqvist
force-pushed
the
minor-fix-warnings-jan-2023
branch
from
506e110
to
73b03c6
Compare
Kyle-Ye
approved these changes
Jan 9, 2023
Since the filter has no effect the second `count > 1` check is redundant
d-ronnqvist
force-pushed
the
minor-fix-warnings-jan-2023
branch
from
73b03c6
to
a8f5886
Compare
d-ronnqvist
commented
Jan 18, 2023
| // Fill in the appropriate values here when that's fixed (https://github.com/apple/swift-docc/issues/441) | ||
| return nil | ||
| } | ||
| // FIXME: Deprecated/Beta markings need platform versions to display properly in Swift-DocC-Render (rdar://56897597) |
There was a problem hiding this comment.
@QuietMisdreavus have I understood correctly that this FIXME applies generally (and should be kept) or did it only imply when "introduced" was nil (which could never happen) in which case the FIXME can be removed?
There was a problem hiding this comment.
I think the comment still applies, since this is where the information will need to go when that's fixed.
|
@swift-ci please test |
|
@swift-ci please test |
ethan-kusters
approved these changes
Feb 1, 2023
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug/issue #, if applicable:
Summary
This fixes a few minor warnings in the code:
sha512Checksumwas renamed tochecksum)nilDependencies
n/a
Testing
n/a
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/testscript and it succeeded