Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API break in #135 (1.3.0) #150

Closed
glbrntt opened this issue Aug 10, 2020 · 2 comments · Fixed by #152
Closed

API break in #135 (1.3.0) #150

glbrntt opened this issue Aug 10, 2020 · 2 comments · Fixed by #152
Milestone

Comments

@glbrntt
Copy link
Contributor

glbrntt commented Aug 10, 2020

In spite of #135 (comment), I think the was API actually broken in #135:

This:

@inlinable
public func debug(_ message: @autoclosure () -> Logger.Message,
                  metadata: @autoclosure () -> Logger.Metadata? = nil,
                  file: String = #file, function: String = #function, line: UInt = #line) {
    ...
}

...is not the same as:

@inlinable
public func debug(_ message: @autoclosure () -> Logger.Message,
                  metadata: @autoclosure () -> Logger.Metadata? = nil,
                  source: @autoclosure () -> String? = nil,
                  file: String = #file, function: String = #function, line: UInt = #line) {
    ...
}

We need to retain the old function signatures in addition to the new ones and just forward the implementation from the old to the new.

@ktoso ktoso changed the title API break in #135 API break in #135 (1.3.0) Aug 12, 2020
@ktoso
Copy link
Member

ktoso commented Aug 13, 2020

🔥 🧯

I see, you're right... eh, what an unlucky release series. Do you want to send in a PR or should I have a look @glbrntt ?

@ktoso ktoso added this to the 1.4.1 milestone Aug 13, 2020
@glbrntt
Copy link
Contributor Author

glbrntt commented Aug 13, 2020

I should be able to get a patch up today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants