Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A note for the readme #172

Closed
dpedley opened this issue Dec 11, 2020 · 3 comments
Closed

A note for the readme #172

dpedley opened this issue Dec 11, 2020 · 3 comments
Labels
docs enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dpedley
Copy link
Contributor

dpedley commented Dec 11, 2020

Expected behavior

package working as a dependency in swift 5.2

Actual behavior

You get this error:
dependency 'Logging' in target 'BestExampleApp' requires explicit declaration; reference the package in the target dependency with '.product(name: "Logging", package: "swift-log")'

Steps to reproduce

Following the README doesn't quite work. as the error says, you have to put the package name in with swift 5.2 so from the readme this section would change:

.target(name: "BestExampleApp", dependencies: ["Logging"]),

^^^ fails, so should become vvv

.target(name: "BestExampleApp", dependencies: [.product(name: "Logging", package: "swift-log")]),
@ktoso
Copy link
Member

ktoso commented Dec 14, 2020

Thanks, yeah technically we were supporting even 5.1 still -- I think it's good to show in the readme the 5.2+ version; or perhaps both?

Could you PR that addition?

@ktoso ktoso added docs enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 14, 2020
@dpedley
Copy link
Contributor Author

dpedley commented Dec 15, 2020

#173

@dpedley
Copy link
Contributor Author

dpedley commented Dec 15, 2020

Closing, will follow up the PR.

@dpedley dpedley closed this as completed Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants