Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "revert" to test toolchain change #13

Merged
merged 7 commits into from Nov 10, 2021

Conversation

Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Nov 3, 2021

Bug/issue #, if applicable:

Summary

Revert #11 and #12 to test the change in the toolchain build.
@franklinsch

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Ran the ./bin/test script and it succeeded

@franklinsch
Copy link
Member

Tracking testing this alongside Swift here: apple/swift#40031

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Nov 4, 2021

The test on Swift repo seems to be success. Could you please run test on this so that we can merge it if it success? @franklinsch

@franklinsch
Copy link
Member

Now that the smoke tests pass, I also triggered toolchain builds in that PR.

@swift-ci please test

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Nov 5, 2021

Now that the smoke tests pass, I also triggered toolchain builds in that PR.

@swift-ci please test

Seems like both smoke tests and toolchain builds are passed. Could you review the change and merge it? @franklinsch

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Nov 10, 2021

@franklinsch Could we run test again and merge it?

@QuietMisdreavus
Copy link
Contributor

@swift-ci Please test

@ethan-kusters
Copy link
Contributor

@swift-ci Please test

Copy link
Contributor

@QuietMisdreavus QuietMisdreavus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Swift toolchains built just fine with this PR, so let's go ahead and (re-)land it!

@QuietMisdreavus QuietMisdreavus merged commit 72552e2 into apple:main Nov 10, 2021
@QuietMisdreavus QuietMisdreavus mentioned this pull request Nov 10, 2021
3 tasks
@Kyle-Ye Kyle-Ye deleted the fix/revert branch November 11, 2021 02:44
@Kyle-Ye Kyle-Ye mentioned this pull request Nov 12, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants