New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "revert" to test toolchain change #13
Conversation
Tracking testing this alongside Swift here: apple/swift#40031 |
The test on Swift repo seems to be success. Could you please run test on this so that we can merge it if it success? @franklinsch |
Now that the smoke tests pass, I also triggered toolchain builds in that PR. @swift-ci please test |
Seems like both smoke tests and toolchain builds are passed. Could you review the change and merge it? @franklinsch |
@franklinsch Could we run test again and merge it? |
@swift-ci Please test |
@swift-ci Please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the Swift toolchains built just fine with this PR, so let's go ahead and (re-)land it!
Bug/issue #, if applicable:
Summary
Revert #11 and #12 to test the change in the toolchain build.
@franklinsch
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/test
script and it succeeded