Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS deprecated API #3

Merged
merged 2 commits into from Nov 2, 2021
Merged

Conversation

Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Oct 17, 2021

Bug/issue #, if applicable:

Summary

Fix deprecated FileHandle.readDataToEndOfFile, Process.launch and Process.launchPath API on macOS since they can be removed at a future release.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Ran the ./bin/test script and it succeeded

Copy link
Contributor

@d-ronnqvist d-ronnqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. These changes look good to me 👍

Swift CI is getting set up in this repo for automated testing, so I will merge this after things are configured.

@franklinsch
Copy link
Member

@swift-ci please test

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 27, 2021

The test-fail is fixed by this PR #9

After it was merged, we can run test again on this branch.

@franklinsch
Copy link
Member

@swift-ci please test Linux

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 27, 2021

Rebased to the fixed-main, should solve the test issue now.

@franklinsch
Copy link
Member

@swift-ci please test

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 27, 2021

I assume the env to be Swift 5.0+, but it seems it uses the Package.swift's Swift version which is 4.2 (A very old version). What's your opinion on bumping the swift version to 5.0+. See this PR #4

@Kyle-Ye Kyle-Ye changed the title Fix deprecated readDataToEndOfFile API Fix macOS deprecated API Oct 28, 2021
@d-ronnqvist
Copy link
Contributor

@swift-ci please test

@Kyle-Ye Kyle-Ye mentioned this pull request Nov 2, 2021
1 task
@franklinsch
Copy link
Member

Thanks for opening this @Kyle-Ye. Since the blocking PR has been merged, can you please rebase, and I'll kick off CI again here? Also, I filed https://bugs.swift.org/browse/SR-15428 to track the issue you're resolving

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Nov 2, 2021

Thanks for opening this @Kyle-Ye. Since the blocking PR has been merged, can you please rebase, and I'll kick off CI again here? Also, I filed bugs.swift.org/browse/SR-15428 to track the issue you're resolving

Done with rebase. Could you help me run test on this again? Thanks

@franklinsch
Copy link
Member

@swift-ci please test

@franklinsch
Copy link
Member

Thanks @Kyle-Ye! I will merge this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants