New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macOS deprecated API #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. These changes look good to me 👍
Swift CI is getting set up in this repo for automated testing, so I will merge this after things are configured.
@swift-ci please test |
The test-fail is fixed by this PR #9 After it was merged, we can run test again on this branch. |
@swift-ci please test Linux |
bf9df2b
to
b2b5dc7
Compare
Rebased to the fixed-main, should solve the test issue now. |
@swift-ci please test |
I assume the env to be Swift 5.0+, but it seems it uses the Package.swift's Swift version which is 4.2 (A very old version). What's your opinion on bumping the swift version to 5.0+. See this PR #4 |
@swift-ci please test |
Thanks for opening this @Kyle-Ye. Since the blocking PR has been merged, can you please rebase, and I'll kick off CI again here? Also, I filed https://bugs.swift.org/browse/SR-15428 to track the issue you're resolving |
3746a42
to
90619fc
Compare
Done with rebase. Could you help me run test on this again? Thanks |
@swift-ci please test |
Thanks @Kyle-Ye! I will merge this |
Bug/issue #, if applicable:
Summary
Fix deprecated
FileHandle.readDataToEndOfFile
,Process.launch
andProcess.launchPath
API on macOS since they can be removed at a future release.Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
./bin/test
script and it succeeded