Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit all public enums #1428

Open
weissi opened this issue Mar 3, 2020 · 0 comments
Open

Audit all public enums #1428

weissi opened this issue Mar 3, 2020 · 0 comments
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Milestone

Comments

@weissi
Copy link
Member

weissi commented Mar 3, 2020

Having public enums is a major burden if you’re API stable and you don’t use the “library evolution” Swift language dialect. SwiftNIO (like all SwiftPM packages) uses the non-lib-evolution dialect and therefore nothing in enums can ever be changed.

This has caused us many issues and for NIO 3 we should audit all public enums and probably make most of them structs with static constructors.

See also:

@weissi weissi added the ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0 label Mar 3, 2020
@weissi weissi added this to the 3.0.0 milestone Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Projects
None yet
Development

No branches or pull requests

1 participant