Use consistent stylesheet indentation #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaishin
requested review from
0xTim,
alexandersandberg,
daveverwer,
dempseyatgithub,
parispittman,
mschinis,
shahmishal,
TimTr,
tomerd and
cthielen
as code owners
There was a problem hiding this comment.
I don't think this is worth doing unless we add Prettier or some other automatic formatting. Otherwise, things will get messy right away again.
Also, which config to use is quite opinionated. Maybe the default Prettier config is the one to go with, as it should be the least opinionated.
|
Update: this came up during the workgroup meeting. The agreement is to add Prettier as part of this PR and tackle automating the checks in a separate task. Also merging should wait for #344 to be merged first. |
kaishin
force-pushed
the
fix-css-indentation
branch
from
eed3aad
to
dbfe740
Compare
daveverwer
approved these changes
Nov 7, 2023
0xTim
approved these changes
Mar 14, 2024
kaishin
force-pushed
the
fix-css-indentation
branch
from
28265c7
to
818c412
Compare
|
@swift-ci please test |
|
@alexandersandberg I went with the absolute minimum Prettier config and re-run it on all files again. |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Stylesheet source files used a mixture of 2-space and 4-space based indentation.
Modifications:
Make all stylesheet files use 2-space indentation.