Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight current page in the navigation bar #522

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Highlight current page in the navigation bar #522

merged 3 commits into from
Mar 14, 2024

Conversation

souhhmm
Copy link
Contributor

@souhhmm souhhmm commented Feb 9, 2024

Motivation:

As per,

made changes to highlight current page in the navigation bar.

Modifications:

  • Updated navigation.html
  • Updated active color to a variable --color-active-nav-item

Result:

The current page will be highlighted in the navigation bar.

image
image

image
image

kaishin
kaishin approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@kaishin kaishin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor formatting change.

assets/stylesheets/_screen.scss Outdated Show resolved Hide resolved
@souhhmm @kaishin
Update assets/stylesheets/_screen.scss
cf47705 
Formatting change

Co-authored-by: Reda Lemeden <git@redalemeden.com>
@souhhmm souhhmm requested a review from kaishin February 9, 2024 16:42
@0xTim
Copy link
Member

0xTim commented Mar 14, 2024

@kaishin is this waiting on anything?

@0xTim
Copy link
Member

0xTim commented Mar 14, 2024

@swift-ci test

@0xTim 0xTim enabled auto-merge (squash) March 14, 2024 00:46
@0xTim
Copy link
Member

0xTim commented Mar 14, 2024

Ah it appears not, will merge

@0xTim 0xTim merged commit 648ebb7 into swiftlang:main Mar 14, 2024
1 check passed
cthielen pushed a commit to Joannis/swift-org-website that referenced this pull request Mar 26, 2024
@souhhmm @kaishin @cthielen
Highlight current page in the navigation bar (swiftlang#522)
2975379 
* Update color to variable

* Update navigation.html

* Update assets/stylesheets/_screen.scss

Formatting change

Co-authored-by: Reda Lemeden <git@redalemeden.com>

---------

Co-authored-by: Reda Lemeden <git@redalemeden.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

@alexandersandberg alexandersandberg Awaiting requested review from alexandersandberg alexandersandberg is a code owner

@daveverwer daveverwer Awaiting requested review from daveverwer daveverwer is a code owner

@dempseyatgithub dempseyatgithub Awaiting requested review from dempseyatgithub dempseyatgithub is a code owner

@parispittman parispittman Awaiting requested review from parispittman parispittman is a code owner

@mschinis mschinis Awaiting requested review from mschinis

@shahmishal shahmishal Awaiting requested review from shahmishal shahmishal is a code owner

@TimTr TimTr Awaiting requested review from TimTr

@tomerd tomerd Awaiting requested review from tomerd

@cthielen cthielen Awaiting requested review from cthielen

@kaishin kaishin Awaiting requested review from kaishin kaishin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@souhhmm @0xTim @kaishin