Enable target with headers but no sources as ClangTarget
#6006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
k-kohey
changed the title
k-kohey
changed the title
MaxDesiatov
changed the title
ClangTarget
k-kohey
requested review from
abertelrud,
neonichu,
tomerd and
elsh
as code owners
|
looks good to me. @neonichu @abertelrud ? |
abertelrud
approved these changes
Jan 3, 2023
|
thanks @k-kohey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change allows the generation of targets containing only header files.
Motivation:
Closes #4806 .
Currently, if we attempt to create a target that does not contain source files, the Swift Package Manager returns an error and prompts us to put the source files. Therefore, it is not possible to create a CLangTarget that only contains header files.
Modifications:
Changed so that if a header file exists, the Target generation process continues even if no source file exists.
Result:
With the changes in this PR, a target that does not contain source files but does contain headers is a CLangTarget.