Add subcommands to install and uninstall packages #6768
Conversation
NSAntoine
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
Seems like everything here has been addressed, could you take a look now? |
| @@ -465,7 +485,7 @@ extension FileSystem { | |||
| return try swiftSDKsDirectory | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
nit: unnecessary trailing newline. To get rid of these altogether you can run ./Utilities/soundness.sh in this package, assuming you have SwiftFormat installed.
There was a problem hiding this comment.
would you be able to push that formatting fix to this branch as well?
There was a problem hiding this comment.
still present in the diff
| } | ||
|
|
||
| try tool.fileSystem.removeFileTree(whatWeWantToRemove.url) | ||
| print("Removed \(name).") |
There was a problem hiding this comment.
Make this more descriptive:
| print("Removed \(name).") | |
| print("Executable product `\(name)` was successfully uninstalled from \(removedExecutable.path).") |
|
@MaxDesiatov All addressed. |
There was a problem hiding this comment.
Thanks! I've addressed formatting issues in a follow-up commit. For the future when contributing to SwiftPM I highly recommend following CONTRIBUTING.md, esp. item 6 WRT formatting and use of SwiftFormat.
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci test windows |
|
@swift-ci smoke test |
|
@swift-ci test windows |
|
@swift-ci smoke test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Rewritten continuation of #5591, however the
updatesubcommand has been taken out temporarily as we figure out the remote-scm situation right now.This adds
swift package experimental-installandswift package experimental-install. Theexperimental-prefix is added since this hasn't gone through Swift Evolution yet.