Restructure project to test SourceGen code generation #2
Conversation
Added a new module "FishyActorsCore", made the necessary types and methods public and added a new test case "GeneratorTest" for this module.
since `resultTypeNaive` already had its trivia removed, and remove trivia from `node.identifier`
|
Hmm... the "restructuring" I don't think is necessary though, right? Because we can test executable targets now: apple/swift-package-manager#3316 Allow unit test targets to import and link executable targets #3316. So we can just add a test target for I ended up breaking my dev env today so can't check right now but I'll check in a bit. |
|
|
||
| private let sourceDirectory: String | ||
| private let verbose: Bool | ||
|
|
||
| var decls: [DistributedActorDecl] = [] | ||
| public var decls: [DistributedActorDecl] = [] |
There was a problem hiding this comment.
please don't make vars public like that;
There should rather be a function that allows returns this -> the run() could return this or there could be another getAnalysedDecls or something
There was a problem hiding this comment.
I removed public here since it wasn't needed anymore. Since Analysis can't be accessed from other modules do you think it's still valuable to add a method to access it? I like the idea of making decls private and having run() return it, do you think that's a better approach?
There was a problem hiding this comment.
I like the idea of making decls private and having run() return it, do you think that's a better approach?
Yeah sounds good :)
FishyTransport/Tests/FishyActorTransportTests/GeneratorTest.swift
Outdated
Show resolved
Hide resolved
FishyTransport/Tests/FishyActorTransportTests/GeneratorTest.swift
Outdated
Show resolved
Hide resolved
Ohhh that's nice, I didn't realise this was possible already, thanks for pointing it out! I will take care to revert the restructuring, it didn't feel like a very nice solution, so I'm happy it isn't needed. |
undo making types and properties public and relocate `Bold` and `Reset` back to their original place
|
Ok, reverted it to how it was before. |
and correct main.swift, `SourceGen` and unit test
|
Now that I understand how the buckets are supposed to be used I implemented a very naïve strategy which just assigns each decl a new bucket in incrementing fashion, which simplified main.swift and the tests. |
| // It will create more buckets than requested if given enough decls | ||
| if currentBucket >= buckets { | ||
| print("Warning: too many distributed actors declared, please increase requested buckets (currently \(buckets) buckets; this is a temporary limitation of FishyTransport).") | ||
| } |
There was a problem hiding this comment.
okey we can do this for now :)
We can do a real thing soon -- basically take the full type name, hash it, and then % with the bucket count :)
|
Great, thanks a lot @odmir ! |
I was working on adding source generation but found out it was already contributed in the previous PR, which is pretty cool because now anyone can more easily experiment with their own distributed actors. Since I was already working on this I thought I would at least contribute:
AnalysisandSourceGentestableSourceGento not depend on a file URL, returning the generated code instead as an array of buckets (as aString), so that tests don't have to generate files and read them backSourceGeninto files by itselfSourceGenSourceGento generate a more consistent formatting of the generated codeIn order to disturb the project as little as possible I restructured the project this way:
AnalysisandSourceGeninto the new moduleAnalysisandSourceGenpublicI am fine with adjusting the PR if there is a more preferable restructuring of the project to make it more testable.
Note: I know this is meant as "just" a small example project, but I think making it more real and functional is a good way to demonstrate the idea and allow people to more easily experiment with their own ideas.