update to shipped language feature (remove codegen, experimental things) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-update-to-shipped-feture
branch
from
35c4a1a
to
cb69375
Compare
|
Optional review @yim-lee if you have some time :) (can't assign as reviewer meh) |
yim-lee
approved these changes
Dec 5, 2022
| case .failure(let error): | ||
| let status: HTTPResponseStatus | ||
| let errorString: String | ||
| if let error = error as? HTTPActorSystemError { |
There was a problem hiding this comment.
Perhaps we can use switch instead of if-else?
There was a problem hiding this comment.
Hmm, not sure I like switch for this kind of thing :~ Mind if I keep it? :)
DistributedSampleHTTP/Sources/DistributedSampleHTTP/HTTPActorSystem.swift
Outdated
Show resolved
Hide resolved
DistributedSampleHTTP/Sources/DistributedSampleHTTP/HTTPActorSystem.swift
Show resolved
Hide resolved
ktoso
force-pushed
the
wip-update-to-shipped-feture
branch
from
6fb6b62
to
f55e8ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 5.7 includes distributed actors now, and we no longer need to do any of the experimental tricks, or source generation in order to showcase the feature.
This implementation is using official released toolchains and is pretty similar to what was presented in https://developer.apple.com/videos/play/wwdc2022/110356/ and previously in this sample repo. I.e. we still use http client and don't really do anything smart, but the focus is about showing the "shape" of an implementation :-)