Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ArrayExpr in SyntaxBuildableChild #548

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix ArrayExpr in SyntaxBuildableChild #548

merged 1 commit into from
Aug 4, 2022

Conversation

fwcd
Copy link
Member

@fwcd fwcd commented Aug 4, 2022

This is a small patch that fixes the (currently broken) SwiftSyntaxBuilderGeneration due to the now missing Array: ExpressibleAsArrayElementList conformance (see #483 (comment)).

@fwcd fwcd requested a review from ahoppen as a code owner August 4, 2022 13:02
@fwcd
Copy link
Member Author

fwcd commented Aug 4, 2022

@swift-ci please test

ahoppen
ahoppen approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I just started looking into the same issue.

@fwcd fwcd merged commit bec0c3d into swiftlang:main Aug 4, 2022
@fwcd fwcd deleted the fix-array-expr branch August 4, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fwcd @ahoppen