Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please remove the v-prefix from the version 0.0.2 tag? #49

Closed
kishikawakatsumi opened this issue May 18, 2021 · 2 comments
Closed

Comments

@kishikawakatsumi
Copy link

The tag for version 0.0.2 now has a prefix of v, unlike the previous tag, which is now v0.0.2.

This will affect automatic updates of Renovate (https://github.com/apps/renovate).
Renovate will automatically create a PR from the GitHub tag as follows

-.package(url: "https://github.com/apple/swift-system", from: "0.0.1"),
+.package(url: "https://github.com/apple/swift-system", from: "v0.0.2"),

This causes an error in the Swift Package Manager.

...
[5/5] RUN cd ./swiftfiddle.com/_Packages/ && swift build -c release:
#8 1.044 /swiftfiddle.com/_Packages: error: manifest parse error(s):
#8 1.044 Invalid semantic version string 'v0.0.2'
...

If it's not important to add the v prefix, could you please revert to the previous format (like 0.0.2)?

@milseman
Copy link
Contributor

Argh, Github even recommends the v prefix through the release UI. I changed it to just use the semver for the tag, hopefully that fixes any issues you have.

@kishikawakatsumi
Copy link
Author

Thank you so much for fixing it so quickly ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants