Build process.c with _GNU_SOURCE #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweimer-rh
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
@swift-ci please test |
neonichu
approved these changes
Nov 4, 2022
compnerd
requested changes
Nov 4, 2022
|
The warning doesn't happen if the redefinition is identical. I think the risk is very small. I can add an I don't want to change the build system because it may have unintended consequences. See the existing comment regarding |
|
IIRC it does if it is from the command line vs builtin vs in the source. At least with CMake we can control it on a per source file level, which keeps the risk profile the same. However, a |
|
Okay, I'll try the |
|
I think that we do have squashes on this repo, so either is fine - it can be squashed before merging. |
Otherwise the build will fail on glibc 2.29 and later because
posix_spawn_file_actions_addchdir_np is not declared.
Starting with glibc 2.37, posix_spawn_file_actions_addchdir_np
will be available with the default feature flags; see glibc
commit 2ff48a4025515e93d722947a9eabb114f4a65b22 ("posix: Make
posix_spawn extensions available by default").
fweimer-rh
requested review from
compnerd
and removed request for
tomerd,
friedbunny,
aciidgh and
abertelrud
This comment was marked as outdated.
This comment was marked as outdated.
|
@swift-ci please test |
compnerd
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the build will fail on glibc 2.29 and later because posix_spawn_file_actions_addchdir_np is not declared.
A glibc change has been submitted as well, but it will not become available until glibc 2.37:
[PATCH] posix: Make posix_spawn extensions available by default https://sourceware.org/pipermail/libc-alpha/2022-November/143197.html