Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-6880] synthesized ObjC constructors with struct parameters are not lowered properly on ARM VFP CC #49429

Open
compnerd opened this issue Jan 31, 2018 · 4 comments

Comments

@compnerd
Copy link
Collaborator

@compnerd compnerd commented Jan 31, 2018

Previous ID SR-6880
Radar None
Original Reporter @compnerd
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Compiler
Labels Bug, Swift4, Windows, arm, armhf, linux
Assignee None
Priority Medium

md5: 61a8547c2722f009225e364a21a95711

Issue Description:

When materializing the implicit constructor containing a HFA, the VFP CC will result in an incorrect attempt to coerce parameters to the structure type. This causes an assertion in LLVM as we attempt to store a structure value into the alloca when trafficking through memory.

@compnerd
Copy link
Collaborator Author

@compnerd compnerd commented Jan 31, 2018

There is a test case for this in PR14304

@belkadan
Copy link
Contributor

@belkadan belkadan commented Feb 1, 2018

Aside: why the "Swift4" label?

@compnerd
Copy link
Collaborator Author

@compnerd compnerd commented Feb 2, 2018

Oh, that is because it shows up in Swift 4 and newer I believe. Is that keyword meant for something else?

@belkadan
Copy link
Contributor

@belkadan belkadan commented Feb 2, 2018

I don't think anyone uses it at all (though it is on a few other bugs). It's interesting to know when something was a regression (4.0Regression, 4.1Regression, etc), but not usually when it's a new feature that just never worked under certain conditions.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants