Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-11464] _withUGR isn't suppressing retain/release as much as it should? #53864

Open
stephentyrone opened this issue Sep 12, 2019 · 4 comments
Open

Comments

@stephentyrone
Copy link
Member

@stephentyrone stephentyrone commented Sep 12, 2019

Previous ID SR-11464
Radar rdar://problem/55320239
Original Reporter @stephentyrone
Type Bug
Additional Detail from JIRA
Votes 0
Component/s Standard Library
Labels Bug, Performance
Assignee None
Priority Medium

md5: eaf8694173330c6f2ae67cd4fa79e551

Issue Description:

https://github.com/frol/completely-unscientific-benchmarks

There's two versions of the Swift benchmark here; the unsafe one uses _withUGR heavily, but I still observed a huge amount of retain/release calls in an instruments trace. I haven't looked into it in any detail, so it's possible that they're coming from some other source, but Karoy and Michael wanted to have a pass over _withUGR anyway, and this is a convenient excuse.

@stephentyrone
Copy link
Member Author

@stephentyrone stephentyrone commented Sep 12, 2019

CC @lorentey@milseman

@milseman
Copy link
Mannequin

@milseman milseman mannequin commented Sep 12, 2019

I think you meant @gottesmm

@stephentyrone
Copy link
Member Author

@stephentyrone stephentyrone commented Sep 12, 2019

Well, Karoy didn't specify, so I had to guess No, he did specify, I just can't read good.

@lorentey
Copy link
Member

@lorentey lorentey commented Sep 12, 2019

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants