Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-13425] 3-7x performance regression between 6-04-a and 7-11-a #55866

Open
tayloraswift opened this issue Aug 20, 2020 · 1 comment
Open

[SR-13425] 3-7x performance regression between 6-04-a and 7-11-a #55866

tayloraswift opened this issue Aug 20, 2020 · 1 comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.

Comments

@tayloraswift
Copy link
Member

Previous ID SR-13425
Radar rdar://problem/67499431
Original Reporter @Kelvin13
Type Bug
Environment

Ubuntu, swift snapshots installed with swiftenv

Additional Detail from JIRA
Votes 0
Component/s
Labels Bug
Assignee None
Priority Medium

md5: ec49b8b464e139278b981e5ca2601dd5

Issue Description:

There seems to be a large three- to sevenfold performance regression between the same framework (Swift PNG) compiled with the 6-04-a snapshot and the 7-11-a snapshot. As of the 8-04-a snapshot, the issue still appears to be present.

The performance regressions were noticed in the benchmarks of the Swift PNG library, at commit 87c8912d61910babd4ceff0786b256a7e78371be. (https://github.com/kelvin13/png/tree/87c8912d61910babd4ceff0786b256a7e78371be)

Instructions for how to run and interpret the benchmarks are in this forum post:

https://forums.swift.org/t/enormous-7x-performance-regression-between-6-04-a-and-7-11-a/39469

The function responsible for most of the benchmark execution time is here:

https://github.com/kelvin13/png/blob/87c8912d61910babd4ceff0786b256a7e78371be/sources/png4/deflate.swift#L1683

@typesanitizer
Copy link

@swift-ci create

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Development

No branches or pull requests

2 participants