It’s okay to use the SR in the names IMHO just add a link to github issue as a comment.

Actually, let us rename these to "issueNNNN", and I will add the links too.

Or some more neutral names would work too if you can come up with good ones. I usually avoid suggesting renaming in tests since I often struggle with that myself :)

"issueNNNN" is IMHO the best one I could come up with as of now. I think "issue" is pretty neutral, in the sense that it need not apply just to bugs, and perhaps better than an abbreviation that is often hard to decipher and more strongly tied to a specific tracking system (like, I still wonder what SR stands for, Swift Radar? 😅).

@hborla What do you think?

What I usually do is wrap everything in a func rdarXXX or func issueYYY and then no need to add anything to the names, but it doesn’t work if you need to declare a protocol or extensions…

Oh, I misunderstood! Yes, I will switch to foo or something for the stuff that I could wrap in a do block—that was an accident. No need for a named wrapper in addition to the issue link, I think.

What I usually do is wrap everything in a func rdarXXX or func issueYYY and then no need to add anything to the names, but it doesn’t work if you need to declare a protocol or extensions…

Yeah I like this strategy too! Lately I've been using it but with more descriptive names (e.g. what the actual issue is) instead of an issue/jira/radar number. An issue link in a comment is perfectly sufficient if the issue has helpful context.

Yeah I like this strategy too! Lately I've been using it but with more descriptive names (e.g. what the actual issue is) instead of an issue/jira/radar number. An issue link in a comment is perfectly sufficient if the issue has helpful context.

Me and Pavel misunderstood each other—I was referring to the "naming convention" that is to replace "SRXXX" , which I proposed to be "issueYYY". But I totally concur that wrapping issue-specific test cases in functions/blocks when possible and mentioning the issue once is a lot neater that sticking the ID in every identifier.

I did understand what you meant and issueXXX is fine, just like we do for rdarYYY and I should have clarified that my suggestion is separate, sorry!