Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR-14026] Doc comment for closure parameters of function parameter: work for top level func, but not nested member func #60696

Open
mattyoung opened this issue Jan 8, 2021 · 2 comments

Comments

@mattyoung
Copy link

Previous ID SR-14026
Radar rdar://problem/73014684
Original Reporter @mattyoung
Type New Feature

Attachment: Download

Additional Detail from JIRA
Votes 0
Component/s SourceKit-LSP
Labels New Feature
Assignee None
Priority Medium

md5: ca46ad50f3aae96616db4981525f6201

Issue Description:

For nested in either an extension or struct member func, the closure parameter doc comment on quick help (option click on symbol in Xcode) show correctly at definition, but not at call site: show "No description"

See: https://forums.swift.org/t/doc-comment-how-to-document-closure-arguments-of-func-argument/41940/9

ClosureParamDocCommentBug.swift

@typesanitizer
Copy link

@swift-ci create

@benlangmuir
Copy link
Member

Another difference is that when you click on the declaration the type is shown with the full `(_ first: Element, _ second: Element)` syntax, but when you click on the call it is collapsed to `(Element, Element)`. We should also check the behaviour across module boundaries.

@swift-ci swift-ci transferred this issue from apple/swift-issues Apr 25, 2022
@shahmishal shahmishal transferred this issue from apple/swift May 9, 2022
@ahoppen ahoppen transferred this issue from apple/sourcekit-lsp Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants