[Concurrency] Diagnose a redundant nonisolated(unsafe)
#72078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simanerush
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
simanerush
force-pushed
the
redundant-nonisolated-unsafe
branch
2 times, most recently
from
13092e0
to
1123bc0
Compare
hborla
reviewed
Mar 5, 2024
simanerush
force-pushed
the
redundant-nonisolated-unsafe
branch
from
355a3aa
to
c9b5791
Compare
|
@swift-ci please smoke test macos |
simanerush
force-pushed
the
redundant-nonisolated-unsafe
branch
from
c9b5791
to
9aa13e0
Compare
…e` immutable storage.
…ed `Sendable` immutable storage.
…solated `Sendable` immutable storage.
simanerush
force-pushed
the
redundant-nonisolated-unsafe
branch
from
9aa13e0
to
a5eff6b
Compare
|
@swift-ci please smoke test |
|
@hborla this should be ready now! |
|
Just wanted to say this rocks |
|
@mattmassicotte Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a static constant property of a struct with a
Sendabletype, warn the user thatnonisolated(unsafe)is redundant.(unsafe)partNotes: this is my first concurrency bug fix, so I would appreciate feedback on the diagnostics messages!
Resolves #71546.