[AST] Fix best import kind when value decl is a typealias of an existential type #72738

li3zhen1 · 2024-03-31T22:48:48Z

Resolves #72724 .

Fixed behaviors:

/Users/lizhen/Projects/swift-projects/build/Ninja-DebugAssert/swift-macosx-arm64/bin/swift-frontend ./moduleB.swift -I . -L . -l./moduleA -typecheck
./moduleB.swift:3:17: error: type alias 'TypeAlias' (aka 'any Protocol') cannot be imported as 'protocol'
1 │
2 │ // Module B
3 │ import protocol ModuleA.TypeAlias 
  │                 ╰─ error: type alias 'TypeAlias' (aka 'any Protocol') cannot be imported as 'protocol'
4 │ import typealias ModuleA.TypeAlias

/Users/lizhen/Projects/swift-debug/./ModuleA.swift:3:18: note: 'TypeAlias' declared here
1 │ // Module A
2 │ public protocol Protocol {}
3 │ public typealias TypeAlias = any Protocol
  │                  ╰─ note: 'TypeAlias' declared here
4 │

…ential type

DougGregor · 2024-04-02T19:58:32Z

@li3zhen1 could you add a test case that checks the new behavior? It could go into test/ImportResolution/import-specific-fixits.swift with other tests of this diagnostic.

li3zhen1 · 2024-04-02T20:36:52Z

Added. Thanks.

simanerush · 2024-06-12T23:49:45Z

@swift-ci please smoke test

AnthonyLatsis

This fix is fine, but that we are looking through existentials in getAnyGeneric is a bit disturbing and rather counterintuitive these days. Could we see whether fixing that instead breaks anything?

swift/lib/AST/Type.cpp

Lines 84 to 86 in e431216

    
           GenericTypeDecl *CanType::getAnyGeneric() const { 
        
             if (auto existential = dyn_cast<ExistentialType>(*this)) 
        
               return existential->getConstraintType()->getAnyGeneric();

li3zhen1 requested review from hborla, slavapestov and xedin as code owners March 31, 2024 22:48

li3zhen1 force-pushed the fix-incorrect-existential-import branch 2 times, most recently from b45bda9 to aaa58a9 Compare April 1, 2024 01:15

[AST] Fix best import kind when value decl is a typealias of an exist…

e738059

…ential type

li3zhen1 force-pushed the fix-incorrect-existential-import branch from aaa58a9 to e738059 Compare April 1, 2024 01:17

[AST] Add test for incorrect existential import

55eb460

AnthonyLatsis reviewed Jun 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AST] Fix best import kind when value decl is a typealias of an existential type #72738

[AST] Fix best import kind when value decl is a typealias of an existential type #72738

li3zhen1 commented Mar 31, 2024 •

edited

DougGregor commented Apr 2, 2024

li3zhen1 commented Apr 2, 2024

simanerush commented Jun 12, 2024

AnthonyLatsis left a comment

	GenericTypeDecl *CanType::getAnyGeneric() const {
	if (auto existential = dyn_cast<ExistentialType>(*this))
	return existential->getConstraintType()->getAnyGeneric();

[AST] Fix best import kind when value decl is a typealias of an existential type #72738

Are you sure you want to change the base?

[AST] Fix best import kind when value decl is a typealias of an existential type #72738

Conversation

li3zhen1 commented Mar 31, 2024 • edited

DougGregor commented Apr 2, 2024

li3zhen1 commented Apr 2, 2024

simanerush commented Jun 12, 2024

AnthonyLatsis left a comment

Choose a reason for hiding this comment

li3zhen1 commented Mar 31, 2024 •

edited