crash with array of C++ objects exposed via SWIFT_SHARED_REFERENCE

[wtholliday]

Description

Exposed a C++ struct via SWIFT_SHARED_REFERENCE. Works when outside an array. When added to an array, crashes when array is deallocated. Please use attached project.

CompilerCrash.zip

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0x20)
    frame #0: 0x000000018466c6b4 libobjc.A.dylib`objc_release + 16
    frame #1: 0x0000000194a8ecf8 libswiftCore.dylib`swift_arrayDestroy + 196
    frame #2: 0x0000000194798cd8 libswiftCore.dylib`Swift._ContiguousArrayStorage.__deallocating_deinit + 96
    frame #3: 0x0000000194aa91a0 libswiftCore.dylib`_swift_release_dealloc + 56
    frame #4: 0x0000000194aa9cf8 libswiftCore.dylib`bool swift::RefCounts<swift::RefCountBitsT<(swift::RefCountInlinedness)1>>::doDecrementSlow<(swift::PerformDeinit)1>(swift::RefCountBitsT<(swift::RefCountInlinedness)1>, unsigned int) + 136
  * frame #5: 0x000000010037a95c CompilerCrash`CompilerCrashApp.init() at CompilerCrashApp.swift:29:5

Reproduction

let thing = SharedThing.create()
let array = [thing]

#include <swift/bridging>

struct SharedThing {
    static SharedThing* _Nonnull create();
} SWIFT_SHARED_REFERENCE(retainSharedThing, releaseSharedThing);

void retainSharedThing(SharedThing * _Nonnull);
void releaseSharedThing(SharedThing * _Nonnull);

Expected behavior

Does not crash

Environment

swift-driver version: 1.90.11.1 Apple Swift version 5.10 (swiftlang-5.10.0.13 clang-1500.3.9.4)
Target: arm64-apple-macosx14.0

Additional information

No response

[wtholliday]

Simpler repro:

CompilerCrash.zip

[MaxDesiatov]

cc @egorzhdan

[egorzhdan]

This was fixed in #73615.
Thanks @wtholliday for a small reproducer!