[Sema/SILGen] Support for fallthrough into cases with pattern variables. #14041
+266
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest / most-restrictive version of this feature. The previous case that we're falling from must have a superset of the bindings of the case we're falling into and all the to-case bindings must match name and type exactly the corresponding from-case binding.
Fallthrough error diagnoses changed for these new rules, Sema changed to check them, SILGen extended to use the same phi argument passing between case blocks for fallthrough that it was already using for multiple patterns. Finally, VarDeclUsage checker changed so that a binding falling through to a next case counts as a read of that decl.
Tests for all the above, including separate SILGen testing for fallthrough of address-only types that @slavapestov recently fixed for multiple patterns.