Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten #file and add #filePath (behind an experimental flag) #25656

Merged
merged 6 commits into from Dec 7, 2019

Conversation

@brentdax
Copy link
Contributor

brentdax commented Jun 21, 2019

#file includes an entire gigantic path whenever it is used, and it is often used implicitly. This has two negative effects: It wastes space on something that is almost never needed and it invisibly embeds information in the binary, such as the developer's username, that they may want to keep private.

This PR changes the behavior of #file so that it evaluates to a short string containing the module name and filename, but not the full path. It also adds #filePath, which continues to give you the absolute path.

These changes are hidden behind a feature flag, -enable-experimental-concise-pound-file, because making them permanent will require an evolution proposal.

This change includes some basic tests with the flag enabled, but they're not comprehensive; for instance, code completion isn't tested anywhere. The implementation for the proposal should update existing #file tests and add matching #filePath tests to ensure adequate coverage.

Progresses towards fixing rdar://problem/56816166.

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Jun 21, 2019

@swift-ci please benchmark

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Jun 21, 2019

Performance: -O

Improvement OLD NEW DELTA RATIO
ObjectiveCBridgeStubFromNSDate 2800 2560 -8.6% 1.09x (?)
DataAccessBytesMedium 47 43 -8.5% 1.09x (?)

Code size: -O

Improvement OLD NEW DELTA RATIO
Fibonacci.o 1612 1516 -6.0% 1.06x
SevenBoom.o 1642 1546 -5.8% 1.06x
ByteSwap.o 1652 1556 -5.8% 1.06x
NSDictionaryCastToSwift.o 1657 1561 -5.8% 1.06x
BitCount.o 1876 1780 -5.1% 1.05x
Ackermann.o 1884 1788 -5.1% 1.05x
DeadArray.o 1892 1796 -5.1% 1.05x
MonteCarloPi.o 1593 1513 -5.0% 1.05x
XorLoop.o 2012 1916 -4.8% 1.05x
RangeIteration.o 1684 1604 -4.8% 1.05x
ProtocolDispatch2.o 1740 1660 -4.6% 1.05x
PointerArithmetics.o 1759 1679 -4.5% 1.05x
Integrate.o 2432 2336 -3.9% 1.04x
OpaqueConsumingUsers.o 2046 1966 -3.9% 1.04x
Memset.o 2148 2068 -3.7% 1.04x
LinkedList.o 2376 2296 -3.4% 1.03x
OpenClose.o 3218 3122 -3.0% 1.03x
ChainedFilterMap.o 2733 2653 -2.9% 1.03x
Calculator.o 2740 2660 -2.9% 1.03x
StrComplexWalk.o 2801 2721 -2.9% 1.03x
DictionaryBridge.o 3390 3294 -2.8% 1.03x
StrToInt.o 3508 3412 -2.7% 1.03x
ArrayLiteral.o 3311 3231 -2.4% 1.02x
MonteCarloE.o 3348 3268 -2.4% 1.02x
RC4.o 4052 3956 -2.4% 1.02x
ArrayInClass.o 4079 3983 -2.4% 1.02x
ArraySubscript.o 3764 3684 -2.1% 1.02x
ObjectAllocation.o 4139 4059 -1.9% 1.02x
PopFront.o 5197 5101 -1.8% 1.02x
Exclusivity.o 4420 4340 -1.8% 1.02x
NopDeinit.o 5584 5488 -1.7% 1.02x
PopFrontGeneric.o 4702 4622 -1.7% 1.02x
RangeAssignment.o 4876 4796 -1.6% 1.02x
DictionaryKeysContains.o 10105 9945 -1.6% 1.02x
DictionaryBridgeToObjC.o 5286 5206 -1.5% 1.02x
DictionaryCopy.o 10933 10773 -1.5% 1.01x
TwoSum.o 5508 5428 -1.5% 1.01x
RangeReplaceableCollectionPlusDefault.o 6077 5997 -1.3% 1.01x
CString.o 8272 8176 -1.2% 1.01x
Combos.o 7232 7152 -1.1% 1.01x
StringInterpolation.o 7251 7171 -1.1% 1.01x
ObjectiveCNoBridgingStubs.o 8836 8740 -1.1% 1.01x
StringRemoveDupes.o 7568 7488 -1.1% 1.01x
BinaryFloatingPointProperties.o 7580 7500 -1.1% 1.01x
Walsh.o 7580 7500 -1.1% 1.01x
RomanNumbers.o 8027 7947 -1.0% 1.01x

Performance: -Osize

Regression OLD NEW DELTA RATIO
DropLastCountableRange 5 6 +20.0% 0.83x (?)
 
Improvement OLD NEW DELTA RATIO
DataAccessBytesMedium 58 50 -13.8% 1.16x (?)
ObjectiveCBridgeStubFromNSStringRef 88 81 -8.0% 1.09x (?)
IterateData 900 833 -7.4% 1.08x
NormalizedIterator_slowerPrenormal 580 540 -6.9% 1.07x (?)

Code size: -Osize

Improvement OLD NEW DELTA RATIO
BitCount.o 1634 1538 -5.9% 1.06x
Fibonacci.o 1642 1546 -5.8% 1.06x
ByteSwap.o 1682 1586 -5.7% 1.06x
NSDictionaryCastToSwift.o 1722 1626 -5.6% 1.06x
SevenBoom.o 1816 1720 -5.3% 1.06x
DeadArray.o 1890 1794 -5.1% 1.05x
MonteCarloPi.o 1578 1498 -5.1% 1.05x
Ackermann.o 1957 1861 -4.9% 1.05x
XorLoop.o 2082 1986 -4.6% 1.05x
RangeIteration.o 1770 1690 -4.5% 1.05x
PointerArithmetics.o 1864 1784 -4.3% 1.04x
Integrate.o 2430 2334 -4.0% 1.04x
OpaqueConsumingUsers.o 2081 2001 -3.8% 1.04x
ProtocolDispatch2.o 2084 2004 -3.8% 1.04x
Memset.o 2098 2018 -3.8% 1.04x
LinkedList.o 2313 2233 -3.5% 1.04x
Calculator.o 2722 2642 -2.9% 1.03x
StrComplexWalk.o 2754 2674 -2.9% 1.03x
DictionaryBridge.o 3484 3388 -2.8% 1.03x
RC4.o 3586 3490 -2.7% 1.03x
OpenClose.o 3672 3576 -2.6% 1.03x
TwoSum.o 3093 3013 -2.6% 1.03x
ArrayLiteral.o 3189 3109 -2.5% 1.03x
ChainedFilterMap.o 3565 3485 -2.2% 1.02x
MonteCarloE.o 3762 3682 -2.1% 1.02x
DictionaryCopy.o 7861 7701 -2.0% 1.02x
ObjectAllocation.o 4046 3966 -2.0% 1.02x
ArraySubscript.o 4067 3987 -2.0% 1.02x
DictionaryKeysContains.o 8172 8012 -2.0% 1.02x
PopFront.o 4990 4894 -1.9% 1.02x
Exclusivity.o 4301 4221 -1.9% 1.02x
StrToInt.o 5236 5140 -1.8% 1.02x
ArrayInClass.o 4548 4465 -1.8% 1.02x
DictionaryBridgeToObjC.o 4619 4539 -1.7% 1.02x
PopFrontGeneric.o 4759 4679 -1.7% 1.02x
StringRemoveDupes.o 4841 4761 -1.7% 1.02x
RangeAssignment.o 5002 4922 -1.6% 1.02x
NopDeinit.o 6260 6164 -1.5% 1.02x
DictionaryRemove.o 11067 10907 -1.4% 1.01x
RangeReplaceableCollectionPlusDefault.o 5693 5613 -1.4% 1.01x
Walsh.o 5796 5716 -1.4% 1.01x
CString.o 8056 7960 -1.2% 1.01x
StringInterpolation.o 6906 6826 -1.2% 1.01x
DictionaryCompactMapValues.o 14133 13973 -1.1% 1.01x
ObjectiveCNoBridgingStubs.o 8495 8399 -1.1% 1.01x
ReversedCollections.o 9938 9826 -1.1% 1.01x
BinaryFloatingPointProperties.o 7396 7316 -1.1% 1.01x
DictionaryOfAnyHashableStrings.o 7549 7469 -1.1% 1.01x
StringTests.o 7716 7636 -1.0% 1.01x
Combos.o 7808 7728 -1.0% 1.01x
DictTest2.o 9689 9593 -1.0% 1.01x

Performance: -Onone

Regression OLD NEW DELTA RATIO
ArrayAppendGenericStructs 620 1100 +77.4% 0.56x (?)

Code size: -swiftlibs

Improvement OLD NEW DELTA RATIO
libswiftSwiftPrivate.dylib 45056 40960 -9.1% 1.10x
libswiftCoreGraphics.dylib 65536 61440 -6.2% 1.07x
libswiftAppKit.dylib 77824 73728 -5.3% 1.06x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB
@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Jun 21, 2019

Okay, "up to 6% code size" is probably a fair summary of that. Let's try compiler performance and look at number of bytes output as a rough proxy for code size of the source compatibility suite.

@swift-ci please test compiler performance

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Jun 21, 2019

Summary for master full

Unexpected test results, excluded stats for ProcedureKit, Tagged, Wordy, SwifterSwift, Deferred

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 29,682,678,275,690 29,782,541,072,705 99,862,797,015 0.34%
LLVM.NumLLVMBytesOutput 1,151,402,786 1,158,336,960 6,934,174 0.6%
time.swift-driver.wall 2743.8s 2756.3s 12.6s 0.46%

debug-batch detailed

Regressed (12)
name old new delta delta_pct
AST.NumDependencies 212,989 216,530 3,541 1.66% ⛔️
AST.NumInfixOperators 34,424 34,812 388 1.13% ⛔️
AST.NumLoadedModules 258,423 262,351 3,928 1.52% ⛔️
AST.NumPrefixOperators 59 60 1 1.69% ⛔️
AST.NumSourceLinesPerSecond 2,396,707 2,427,196 30,489 1.27% ⛔️
Driver.ChildrenMaxRSS 136,886,734,848 139,146,248,192 2,259,513,344 1.65% ⛔️
SILModule.NumSILGenGlobalVariables 36,222 36,840 618 1.71% ⛔️
SILModule.NumSILOptGlobalVariables 37,093 37,716 623 1.68% ⛔️
SILModule.NumSILOptWitnessTables 99,956 101,019 1,063 1.06% ⛔️
Sema.DefaultAndMaxAccessLevelRequest 58,124 58,835 711 1.22% ⛔️
Sema.DefaultTypeRequest 318,269 323,323 5,054 1.59% ⛔️
Sema.NumUnloadedLazyIterableDeclContexts 4,142,557 4,192,782 50,225 1.21% ⛔️
Improved (3)
name old new delta delta_pct
Driver.NumDriverPipePolls 100,352 97,837 -2,515 -2.51%
Driver.NumDriverPipeReads 99,527 96,943 -2,584 -2.6%
Sema.USRGenerationRequest 12,093,916 11,923,138 -170,778 -1.41%
Unchanged (delta < 1.0% or delta < 100.0ms) (100)
name old new delta delta_pct
AST.NumASTBytesAllocated 69,008,214,383 68,948,117,227 -60,097,156 -0.09%
AST.NumDecls 92,836 93,543 707 0.76%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLocalTypeDecls 123 123 0 0.0%
AST.NumObjCMethods 15,278 15,290 12 0.08%
AST.NumPostfixOperators 18 18 0 0.0%
AST.NumPrecedenceGroups 17,071 17,193 122 0.71%
AST.NumReferencedDynamicNames 122 122 0 0.0%
AST.NumReferencedMemberNames 4,040,289 4,071,570 31,281 0.77%
AST.NumReferencedTopLevelNames 312,764 315,682 2,918 0.93%
AST.NumSourceBuffers 396,318 399,348 3,030 0.76%
AST.NumSourceLines 3,093,375 3,118,982 25,607 0.83%
AST.NumStoredPropertiesQueries 9,146,829 9,229,756 82,927 0.91%
AST.NumTotalClangImportedEntities 4,340,470 4,343,912 3,442 0.08%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 18,877 19,038 161 0.85%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 853,783,398,432 861,512,381,568 7,728,983,136 0.91%
Frontend.NumInstructionsExecuted 29,682,678,275,690 29,782,541,072,705 99,862,797,015 0.34%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 119,930 120,775 845 0.7%
IRModule.NumIRBasicBlocks 4,577,099 4,612,269 35,170 0.77%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 2,126,593 2,144,134 17,541 0.82%
IRModule.NumIRGlobals 2,227,720 2,245,324 17,604 0.79%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 60,600,113 60,943,978 343,865 0.57%
IRModule.NumIRNamedMetaData 91,740 92,490 750 0.82%
IRModule.NumIRValueSymbols 3,892,400 3,922,872 30,472 0.78%
LLVM.NumLLVMBytesOutput 1,151,402,786 1,158,336,960 6,934,174 0.6%
Parse.NumFunctionsParsed 169,817 171,430 1,613 0.95%
Parse.NumIterableDeclContextParsed 1,163,720 1,174,574 10,854 0.93%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,071,364 1,081,632 10,268 0.96%
SILModule.NumSILGenVtables 12,362 12,417 55 0.44%
SILModule.NumSILGenWitnessTables 45,612 46,027 415 0.91%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 1,521,606 1,536,689 15,083 0.99%
SILModule.NumSILOptVtables 20,489 20,593 104 0.51%
Sema.AccessLevelRequest 2,726,309 2,745,721 19,412 0.71%
Sema.AttachedFunctionBuilderRequest 0 0 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 322,538 325,238 2,700 0.84%
Sema.AttachedPropertyWrappersRequest 1,315,287 1,325,919 10,632 0.81%
Sema.CustomAttrNominalRequest 0 0 0 0.0%
Sema.DefaultDefinitionTypeRequest 5,474 5,525 51 0.93%
Sema.EnumRawTypeRequest 17,220 17,342 122 0.71%
Sema.ExtendedNominalRequest 3,430,113 3,453,753 23,640 0.69%
Sema.FunctionBuilderTypeRequest 0 0 0 0.0%
Sema.InheritedDeclsReferencedRequest 3,871,859 3,871,588 -271 -0.01%
Sema.InheritedTypeRequest 235,936 236,731 795 0.34%
Sema.IsDynamicRequest 1,962,546 1,979,688 17,142 0.87%
Sema.IsFinalRequest 3,535,440 3,541,514 6,074 0.17%
Sema.IsGetterMutatingRequest 397,759 401,137 3,378 0.85%
Sema.IsObjCRequest 1,788,256 1,802,040 13,784 0.77%
Sema.IsSetterMutatingRequest 276,666 279,242 2,576 0.93%
Sema.LazyStoragePropertyRequest 2,417 2,418 1 0.04%
Sema.MangleLocalTypeDeclRequest 246 246 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 21,948 21,911 -37 -0.17%
Sema.NamedLazyMemberLoadSuccessCount 19,429,390 19,615,822 186,432 0.96%
Sema.NominalTypeLookupDirectCount 24,184,745 24,279,402 94,657 0.39%
Sema.NumConformancesDeserialized 6,252,134 6,267,827 15,693 0.25%
Sema.NumConstraintScopes 18,222,571 18,299,055 76,484 0.42%
Sema.NumConstraintsConsideredForEdgeContraction 56,062,479 56,161,432 98,953 0.18%
Sema.NumDeclsDeserialized 47,423,137 47,495,819 72,682 0.15%
Sema.NumDeclsFinalized 1,718,019 1,732,385 14,366 0.84%
Sema.NumDeclsTypechecked 881,539 889,394 7,855 0.89%
Sema.NumDeclsValidated 2,288,325 2,307,488 19,163 0.84%
Sema.NumFunctionsTypechecked 196,395 198,299 1,904 0.97%
Sema.NumGenericSignatureBuilders 1,140,636 1,146,777 6,141 0.54%
Sema.NumLazyGenericEnvironments 9,614,817 9,676,745 61,928 0.64%
Sema.NumLazyGenericEnvironmentsLoaded 220,312 222,035 1,723 0.78%
Sema.NumLazyIterableDeclContexts 6,328,680 6,378,423 49,743 0.79%
Sema.NumLeafScopes 11,714,401 11,764,156 49,755 0.42%
Sema.NumTypesDeserialized 15,696,116 15,799,728 103,612 0.66%
Sema.NumTypesValidated 1,714,759 1,728,520 13,761 0.8%
Sema.OpaqueReadOwnershipRequest 419,746 423,239 3,493 0.83%
Sema.OverriddenDeclsRequest 7,472,016 7,404,520 -67,496 -0.9%
Sema.PropertyWrapperBackingPropertyInfoRequest 320,070 322,765 2,695 0.84%
Sema.PropertyWrapperBackingPropertyTypeRequest 322,538 325,238 2,700 0.84%
Sema.PropertyWrapperTypeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 66,905 67,192 287 0.43%
Sema.RequirementSignatureRequest 69,706 69,945 239 0.34%
Sema.SelfAccessKindRequest 4,306,633 4,312,389 5,756 0.13%
Sema.SelfBoundsFromWhereClauseRequest 5,012,176 5,013,020 844 0.02%
Sema.SetterAccessLevelRequest 154,989 156,462 1,473 0.95%
Sema.StructuralTypeRequest 0 0 0 0.0%
Sema.SuperclassDeclRequest 330,281 333,271 2,990 0.91%
Sema.SuperclassTypeRequest 39,927 40,164 237 0.59%
Sema.TypeDeclsFromWhereClauseRequest 31,278 31,566 288 0.92%
Sema.UnderlyingTypeDeclsReferencedRequest 166,182 166,736 554 0.33%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 30,799,942,280,191 30,800,619,184,698 676,904,507 0.0%
LLVM.NumLLVMBytesOutput 993,288,804 992,861,752 -427,052 -0.04%
time.swift-driver.wall 5199.8s 5203.7s 3.9s 0.08%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (21)
name old new delta delta_pct
AST.NumLoadedModules 17,619 17,619 0 0.0%
AST.NumTotalClangImportedEntities 778,391 778,391 0 0.0%
IRModule.NumIRBasicBlocks 3,937,312 3,937,312 0 0.0%
IRModule.NumIRFunctions 1,811,913 1,811,913 0 0.0%
IRModule.NumIRGlobals 1,989,711 1,989,887 176 0.01%
IRModule.NumIRInsts 36,174,130 36,174,130 0 0.0%
IRModule.NumIRValueSymbols 3,533,081 3,533,081 0 0.0%
LLVM.NumLLVMBytesOutput 993,288,804 992,861,752 -427,052 -0.04%
SILModule.NumSILGenFunctions 748,037 748,037 0 0.0%
SILModule.NumSILOptFunctions 1,001,993 1,001,993 0 0.0%
Sema.NumConformancesDeserialized 2,289,740 2,289,740 0 0.0%
Sema.NumConstraintScopes 17,967,054 17,967,282 228 0.0%
Sema.NumDeclsDeserialized 6,169,064 6,169,064 0 0.0%
Sema.NumDeclsValidated 1,196,806 1,196,806 0 0.0%
Sema.NumFunctionsTypechecked 201,866 201,866 0 0.0%
Sema.NumGenericSignatureBuilders 209,325 209,325 0 0.0%
Sema.NumLazyGenericEnvironments 1,264,871 1,264,871 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 22,181 22,181 0 0.0%
Sema.NumLazyIterableDeclContexts 765,208 765,208 0 0.0%
Sema.NumTypesDeserialized 3,268,505 3,268,505 0 0.0%
Sema.NumTypesValidated 741,424 741,424 0 0.0%
@brentdax brentdax force-pushed the brentdax:file-name-basis branch from 3641b30 to 8dc50eb Nov 16, 2019
@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 16, 2019

@swift-ci please smoke test

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 16, 2019

@swift-ci please benchmark

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 16, 2019

@swift-ci please test compiler performance

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 16, 2019

macOS test failures are examples of the feature working correctly, but affecting tests I didn't update. I'm not sure why they didn't run locally. 🤷‍♂️

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 16, 2019

Performance: -O

Regression OLD NEW DELTA RATIO
NSStringConversion.Long 495 567 +14.5% 0.87x
UTF8Decode_InitDecoding 110 122 +10.9% 0.90x (?)
NSStringConversion.Medium 238 262 +10.1% 0.91x
DictionaryGroup 146 157 +7.5% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
EqualSubstringSubstring 27 21 -22.2% 1.29x (?)
LessSubstringSubstring 27 21 -22.2% 1.29x
EqualSubstringString 27 21 -22.2% 1.29x
LessSubstringSubstringGenericComparable 27 21 -22.2% 1.29x
EqualStringSubstring 28 22 -21.4% 1.27x
EqualSubstringSubstringGenericEquatable 28 22 -21.4% 1.27x
ReversedDictionary2 239 213 -10.9% 1.12x
StringComparison_longSharedPrefix 356 319 -10.4% 1.12x
LazilyFilteredArrayContains 18500 16700 -9.7% 1.11x (?)
ArraySetElement 284 263 -7.4% 1.08x (?)
ParseInt.Small.Hex 232 216 -6.9% 1.07x (?)

Code size: -O

Improvement OLD NEW DELTA RATIO
Fibonacci.o 1561 1481 -5.1% 1.05x
SevenBoom.o 1575 1495 -5.1% 1.05x
ByteSwap.o 1585 1505 -5.0% 1.05x
Ackermann.o 1796 1716 -4.5% 1.05x
DeadArray.o 1809 1729 -4.4% 1.05x
BitCount.o 1841 1761 -4.3% 1.05x
MonteCarloPi.o 1546 1482 -4.1% 1.04x
RangeIteration.o 1551 1487 -4.1% 1.04x
XorLoop.o 1940 1860 -4.1% 1.04x
NSDictionaryCastToSwift.o 1576 1512 -4.1% 1.04x
ProtocolDispatch2.o 1657 1593 -3.9% 1.04x
LinkedList.o 2074 1994 -3.9% 1.04x
PointerArithmetics.o 1694 1630 -3.8% 1.04x
Integrate.o 2262 2182 -3.5% 1.04x
OpaqueConsumingUsers.o 1967 1903 -3.3% 1.03x
Memset.o 2084 2020 -3.1% 1.03x
Calculator.o 2673 2593 -3.0% 1.03x
OpenClose.o 3200 3120 -2.5% 1.03x
MonteCarloE.o 3260 3180 -2.5% 1.03x
StrComplexWalk.o 2738 2674 -2.3% 1.02x
StrToInt.o 3449 3369 -2.3% 1.02x
RC4.o 3695 3615 -2.2% 1.02x
ArrayInClass.o 3948 3868 -2.0% 1.02x
DictionaryBridge.o 3181 3117 -2.0% 1.02x
ArrayLiteral.o 3197 3133 -2.0% 1.02x
ChainedFilterMap.o 3445 3381 -1.9% 1.02x
Exclusivity.o 4338 4258 -1.8% 1.02x
ArraySubscript.o 3634 3570 -1.8% 1.02x
ObjectAllocation.o 3981 3917 -1.6% 1.02x
PopFront.o 5115 5035 -1.6% 1.02x
NopDeinit.o 5297 5217 -1.5% 1.02x
PopFrontGeneric.o 4560 4496 -1.4% 1.01x
DictionaryCopy.o 10438 10294 -1.4% 1.01x
RangeAssignment.o 4775 4711 -1.3% 1.01x
DictionaryKeysContains.o 9783 9655 -1.3% 1.01x
TwoSum.o 5144 5080 -1.2% 1.01x
ReversedCollections.o 10318 10190 -1.2% 1.01x
CString.o 7768 7688 -1.0% 1.01x

Performance: -Osize

Regression OLD NEW DELTA RATIO
NSStringConversion.Long 486 549 +13.0% 0.89x
UTF8Decode_InitDecoding 112 123 +9.8% 0.91x (?)
IterateData 871 949 +9.0% 0.92x (?)
NSStringConversion.Medium 236 255 +8.1% 0.93x (?)
Set.isSuperset.Seq.Empty.Int 51 55 +7.8% 0.93x (?)
 
Improvement OLD NEW DELTA RATIO
LessSubstringSubstring 27 21 -22.2% 1.29x
EqualSubstringString 27 21 -22.2% 1.29x
LessSubstringSubstringGenericComparable 27 21 -22.2% 1.29x
EqualSubstringSubstring 28 22 -21.4% 1.27x (?)
EqualStringSubstring 28 22 -21.4% 1.27x
EqualSubstringSubstringGenericEquatable 28 22 -21.4% 1.27x
FlattenListLoop 3162 2635 -16.7% 1.20x (?)
StringComparison_longSharedPrefix 357 319 -10.6% 1.12x
RemoveWhereMoveInts 19 17 -10.5% 1.12x
Array2D 4160 3744 -10.0% 1.11x
Set.isDisjoint.Seq.Box.Empty 91 83 -8.8% 1.10x (?)
Set.isDisjoint.Seq.Int.Empty 49 45 -8.2% 1.09x (?)
Set.isStrictSubset.Int.Empty 51 47 -7.8% 1.09x (?)
DistinctClassFieldAccesses 205 189 -7.8% 1.08x (?)
ArraySetElement 284 264 -7.0% 1.08x (?)

Code size: -Osize

Improvement OLD NEW DELTA RATIO
BitCount.o 1585 1505 -5.0% 1.05x
Fibonacci.o 1593 1513 -5.0% 1.05x
ByteSwap.o 1617 1537 -4.9% 1.05x
SevenBoom.o 1767 1687 -4.5% 1.05x
Ackermann.o 1802 1722 -4.4% 1.05x
DeadArray.o 1825 1745 -4.4% 1.05x
MonteCarloPi.o 1513 1449 -4.2% 1.04x
XorLoop.o 1908 1828 -4.2% 1.04x
RangeIteration.o 1559 1495 -4.1% 1.04x
NSDictionaryCastToSwift.o 1591 1527 -4.0% 1.04x
LinkedList.o 2129 2049 -3.8% 1.04x
PointerArithmetics.o 1733 1669 -3.7% 1.04x
Integrate.o 2278 2198 -3.5% 1.04x
Memset.o 1920 1856 -3.3% 1.03x
ProtocolDispatch2.o 1979 1915 -3.2% 1.03x
OpaqueConsumingUsers.o 2030 1966 -3.2% 1.03x
Calculator.o 2673 2593 -3.0% 1.03x
RC4.o 3339 3259 -2.4% 1.02x
StrComplexWalk.o 2705 2641 -2.4% 1.02x
OpenClose.o 3544 3464 -2.3% 1.02x
MonteCarloE.o 3574 3494 -2.2% 1.02x
TwoSum.o 2918 2854 -2.2% 1.02x
ArrayLiteral.o 2941 2877 -2.2% 1.02x
Exclusivity.o 4139 4059 -1.9% 1.02x
DictionaryCopy.o 7506 7362 -1.9% 1.02x
DictionaryBridge.o 3373 3309 -1.9% 1.02x
ChainedFilterMap.o 3381 3317 -1.9% 1.02x
DictionaryKeysContains.o 7271 7143 -1.8% 1.02x
ArraySubscript.o 3738 3674 -1.7% 1.02x
PopFront.o 4819 4739 -1.7% 1.02x
ObjectAllocation.o 3933 3869 -1.6% 1.02x
ArrayInClass.o 4223 4155 -1.6% 1.02x
StrToInt.o 5063 4983 -1.6% 1.02x
StringRemoveDupes.o 4517 4453 -1.4% 1.01x
PopFrontGeneric.o 4589 4525 -1.4% 1.01x
DictionaryRemove.o 10624 10480 -1.4% 1.01x
RangeAssignment.o 4868 4804 -1.3% 1.01x
NopDeinit.o 6257 6177 -1.3% 1.01x
Walsh.o 5524 5460 -1.2% 1.01x
ReversedCollections.o 8375 8279 -1.1% 1.01x
DictionaryBridgeToObjC.o 4215 4167 -1.1% 1.01x
DictionaryCompactMapValues.o 12743 12599 -1.1% 1.01x
StringTests.o 7569 7489 -1.1% 1.01x
CString.o 7696 7616 -1.0% 1.01x

Performance: -Onone

Regression OLD NEW DELTA RATIO
UTF8Decode_InitDecoding 129 146 +13.2% 0.88x (?)
DataCountMedium 45 50 +11.1% 0.90x (?)
 
Improvement OLD NEW DELTA RATIO
EqualSubstringSubstringGenericEquatable 31 25 -19.4% 1.24x
LessSubstringSubstringGenericComparable 31 25 -19.4% 1.24x
EqualSubstringSubstring 32 26 -18.7% 1.23x
LessSubstringSubstring 32 26 -18.7% 1.23x
EqualStringSubstring 32 26 -18.7% 1.23x (?)
EqualSubstringString 32 26 -18.7% 1.23x
ArrayOfPOD 723 646 -10.7% 1.12x (?)
ObjectiveCBridgeStubDateMutation 457 414 -9.4% 1.10x
ArrayAppend 2790 2530 -9.3% 1.10x (?)
DataSubscriptMedium 61 56 -8.2% 1.09x (?)

Code size: -swiftlibs

Improvement OLD NEW DELTA RATIO
libswiftSwiftPrivate.dylib 40960 36864 -10.0% 1.11x
libswiftCoreGraphics.dylib 61440 57344 -6.7% 1.07x
libswiftsimd.dylib 135168 131072 -3.0% 1.03x
libswiftSwiftOnoneSupport.dylib 180224 176128 -2.3% 1.02x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac mini
  Model Identifier: Macmini8,1
  Processor Name: Intel Core i7
  Processor Speed: 3.2 GHz
  Number of Processors: 1
  Total Number of Cores: 6
  L2 Cache (per Core): 256 KB
  L3 Cache: 12 MB
  Memory: 64 GB
@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 17, 2019

Summary for master full

Unexpected test results, excluded stats for RxCocoa, Base64CoderSwiftUI, SwifterSwift

Regressions found (see below)

Debug-batch

debug-batch brief

Regressed (0)
name old new delta delta_pct
Improved (1)
name old new delta delta_pct
time.swift-driver.wall 5315.9s 5252.4s -63.5s -1.19%
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 47,996,955,139,115 47,536,877,043,873 -460,078,095,242 -0.96%
LLVM.NumLLVMBytesOutput 1,774,230,810 1,772,637,792 -1,593,018 -0.09%

debug-batch detailed

Regressed (3)
name old new delta delta_pct
AST.NumSourceLinesPerSecond 3,322,695 3,436,509 113,814 3.43% ⛔️
Driver.NumDriverPipePolls 76,534 77,895 1,361 1.78% ⛔️
Driver.NumDriverPipeReads 64,542 66,104 1,562 2.42% ⛔️
Improved (5)
name old new delta delta_pct
Sema.AccessLevelRequest 12,057,976 11,860,013 -197,963 -1.64%
Sema.CollectOverriddenDeclsRequest 7,147,091 7,019,356 -127,735 -1.79%
Sema.GenericParamListRequest 10,166,946 10,050,984 -115,962 -1.14%
Sema.ProvideDefaultImplForRequest 7,147,091 7,019,356 -127,735 -1.79%
Sema.USRGenerationRequest 8,515,181 8,384,570 -130,611 -1.53%
Unchanged (delta < 1.0% or delta < 100.0ms) (194)
name old new delta delta_pct
AST.ImportSetCacheHit 1,880,928 1,881,216 288 0.02%
AST.ImportSetCacheMiss 983,597 983,549 -48 -0.0%
AST.ImportSetFoldHit 527,463 527,446 -17 -0.0%
AST.ImportSetFoldMiss 456,134 456,103 -31 -0.01%
AST.ModuleShadowCacheHit 2,027 2,027 0 0.0%
AST.ModuleShadowCacheMiss 1,602 1,602 0 0.0%
AST.ModuleVisibilityCacheHit 31,223 31,223 0 0.0%
AST.ModuleVisibilityCacheMiss 8,289 8,289 0 0.0%
AST.NumASTBytesAllocated 62,401,935,807 61,861,598,271 -540,337,536 -0.87%
AST.NumASTScopeLookups 4,168,805 4,168,913 108 0.0%
AST.NumBraceStmtASTScopeExpansions 618,853 618,853 0 0.0%
AST.NumBraceStmtASTScopes 618,853 618,853 0 0.0%
AST.NumDecls 138,608 138,608 0 0.0%
AST.NumDependencies 418,426 418,422 -4 -0.0%
AST.NumInfixOperators 53,324 53,324 0 0.0%
AST.NumIterableTypeBodyASTScopeExpansions 264,900 264,902 2 0.0%
AST.NumIterableTypeBodyASTScopes 347,633 347,568 -65 -0.02%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 393,862 393,862 0 0.0%
AST.NumLocalTypeDecls 250 250 0 0.0%
AST.NumLookupInModule 6,525,092 6,528,573 3,481 0.05%
AST.NumLookupQualifiedInAnyObject 291 291 0 0.0%
AST.NumLookupQualifiedInModule 2,800,578 2,803,952 3,374 0.12%
AST.NumLookupQualifiedInNominal 7,899,009 7,884,956 -14,053 -0.18%
AST.NumModuleLookupClassMember 7,167 7,167 0 0.0%
AST.NumModuleLookupValue 48,042,197 48,045,134 2,937 0.01%
AST.NumObjCMethods 24,210 24,210 0 0.0%
AST.NumPostfixOperators 49 49 0 0.0%
AST.NumPrecedenceGroups 25,489 25,489 0 0.0%
AST.NumPrefixOperators 99 99 0 0.0%
AST.NumReferencedDynamicNames 199 199 0 0.0%
AST.NumReferencedMemberNames 6,254,484 6,254,484 0 0.0%
AST.NumReferencedTopLevelNames 473,482 473,482 0 0.0%
AST.NumSourceBuffers 573,884 573,884 0 0.0%
AST.NumSourceLines 4,663,327 4,663,327 0 0.0%
AST.NumTotalClangImportedEntities 6,181,213 6,176,712 -4,501 -0.07%
AST.NumUnqualifiedLookup 4,330,408 4,330,516 108 0.0%
Driver.ChildrenMaxRSS 236,984,033,280 237,234,290,688 250,257,408 0.11%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 27,665 27,665 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.MaxMallocUsage 1,163,078,425,408 1,159,339,955,936 -3,738,469,472 -0.32%
Frontend.NumInstructionsExecuted 47,996,955,139,115 47,536,877,043,873 -460,078,095,242 -0.96%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 195,446 195,446 0 0.0%
IRModule.NumIRBasicBlocks 6,752,566 6,752,566 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 3,322,340 3,322,340 0 0.0%
IRModule.NumIRGlobals 3,616,128 3,622,712 6,584 0.18%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 86,176,619 86,176,619 0 0.0%
IRModule.NumIRNamedMetaData 133,585 133,585 0 0.0%
IRModule.NumIRValueSymbols 6,287,966 6,287,966 0 0.0%
LLVM.NumLLVMBytesOutput 1,774,230,810 1,772,637,792 -1,593,018 -0.09%
Parse.NumFunctionsParsed 265,969 265,969 0 0.0%
Parse.NumIterableDeclContextParsed 907,706 907,718 12 0.0%
Parse.ParseAbstractFunctionBodyRequest 248,157 248,157 0 0.0%
Parse.ParseMembersRequest 743,280 743,292 12 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 1,695,666 1,695,666 0 0.0%
SILModule.NumSILGenGlobalVariables 52,820 52,820 0 0.0%
SILModule.NumSILGenVtables 18,505 18,505 0 0.0%
SILModule.NumSILGenWitnessTables 71,484 71,484 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 2,428,917 2,428,917 0 0.0%
SILModule.NumSILOptGlobalVariables 54,406 54,406 0 0.0%
SILModule.NumSILOptVtables 31,180 31,180 0 0.0%
SILModule.NumSILOptWitnessTables 156,516 156,516 0 0.0%
Sema.AbstractGenericSignatureRequest 34,566 34,566 0 0.0%
Sema.AreAllStoredPropertiesDefaultInitableRequest 23,178 23,178 0 0.0%
Sema.AttachedFunctionBuilderRequest 3 3 0 0.0%
Sema.AttachedPropertyWrapperTypeRequest 539,465 539,465 0 0.0%
Sema.AttachedPropertyWrappersRequest 2,225,966 2,225,976 10 0.0%
Sema.ClassAncestryFlagsRequest 108,696 108,696 0 0.0%
Sema.CompareDeclSpecializationRequest 467,116 466,689 -427 -0.09%
Sema.CursorInfoRequest 0 0 0 0.0%
Sema.CustomAttrNominalRequest 3 3 0 0.0%
Sema.DefaultAndMaxAccessLevelRequest 57,532 57,522 -10 -0.02%
Sema.DefaultArgumentExprRequest 36,691 36,691 0 0.0%
Sema.DefaultArgumentInitContextRequest 452 452 0 0.0%
Sema.DefaultDefinitionTypeRequest 7,815 7,815 0 0.0%
Sema.DefaultTypeRequest 460,721 460,721 0 0.0%
Sema.EmittedMembersRequest 27,829 27,829 0 0.0%
Sema.EnumRawTypeRequest 24,908 24,908 0 0.0%
Sema.EnumRawValuesRequest 10,921 10,921 0 0.0%
Sema.ExistentialConformsToSelfRequest 24,266 24,248 -18 -0.07%
Sema.ExistentialTypeSupportedRequest 17,657 17,657 0 0.0%
Sema.ExpandASTScopeRequest 7,539,844 7,539,803 -41 -0.0%
Sema.ExtendedNominalRequest 870,688 870,688 0 0.0%
Sema.ExtendedTypeRequest 81,735 81,732 -3 -0.0%
Sema.FunctionBuilderTypeRequest 3 3 0 0.0%
Sema.FunctionOperatorRequest 72,728 72,728 0 0.0%
Sema.GenericSignatureRequest 3,180,501 3,178,718 -1,783 -0.06%
Sema.GetDestructorRequest 28,095 28,095 0 0.0%
Sema.HasCircularInheritanceRequest 23,716 23,716 0 0.0%
Sema.HasCircularInheritedProtocolsRequest 10,170 10,170 0 0.0%
Sema.HasCircularRawValueRequest 8,436 8,436 0 0.0%
Sema.HasDefaultInitRequest 56,320 56,320 0 0.0%
Sema.HasDynamicMemberLookupAttributeRequest 0 0 0 0.0%
Sema.HasMemberwiseInitRequest 20,083 20,083 0 0.0%
Sema.HasUserDefinedDesignatedInitRequest 56,330 56,330 0 0.0%
Sema.InferredGenericSignatureRequest 186,834 186,835 1 0.0%
Sema.InheritedDeclsReferencedRequest 6,075,237 6,052,749 -22,488 -0.37%
Sema.InheritedTypeRequest 306,302 306,473 171 0.06%
Sema.InheritsSuperclassInitializersRequest 29,856 29,856 0 0.0%
Sema.InitKindRequest 97,887 97,887 0 0.0%
Sema.InterfaceTypeRequest 14,606,685 14,493,811 -112,874 -0.77%
Sema.IsABICompatibleOverrideRequest 135,479 135,479 0 0.0%
Sema.IsAccessorTransparentRequest 317,366 317,366 0 0.0%
Sema.IsDeclApplicableRequest 0 0 0 0.0%
Sema.IsDynamicRequest 1,749,068 1,749,068 0 0.0%
Sema.IsFinalRequest 2,641,928 2,626,527 -15,401 -0.58%
Sema.IsGetterMutatingRequest 433,278 433,278 0 0.0%
Sema.IsImplicitlyUnwrappedOptionalRequest 2,524,972 2,526,154 1,182 0.05%
Sema.IsObjCRequest 1,583,666 1,581,695 -1,971 -0.12%
Sema.IsSetterMutatingRequest 344,026 344,026 0 0.0%
Sema.IsStaticRequest 3,731,455 3,731,786 331 0.01%
Sema.LazyStoragePropertyRequest 2,550 2,550 0 0.0%
Sema.LookupPrecedenceGroupRequest 173,735 173,735 0 0.0%
Sema.MangleLocalTypeDeclRequest 500 500 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 21,014 21,010 -4 -0.02%
Sema.NamedLazyMemberLoadSuccessCount 29,832,919 29,839,969 7,050 0.02%
Sema.NamingPatternRequest 202,374 202,384 10 0.0%
Sema.NeedsNewVTableEntryRequest 689,451 689,451 0 0.0%
Sema.NominalTypeLookupDirectCount 35,855,529 35,782,245 -73,284 -0.2%
Sema.NumAccessorBodiesSynthesized 187,620 187,620 0 0.0%
Sema.NumAccessorsSynthesized 294,500 294,500 0 0.0%
Sema.NumConformancesDeserialized 9,370,794 9,290,799 -79,995 -0.85%
Sema.NumConstraintScopes 27,278,029 27,270,466 -7,563 -0.03%
Sema.NumConstraintsConsideredForEdgeContraction 86,482,694 86,481,716 -978 -0.0%
Sema.NumCyclicOneWayComponentsCollapsed 0 0 0 0.0%
Sema.NumDeclsDeserialized 74,872,218 74,344,623 -527,595 -0.7%
Sema.NumDeclsTypechecked 1,403,164 1,403,164 0 0.0%
Sema.NumFunctionsTypechecked 527,795 527,795 0 0.0%
Sema.NumGenericSignatureBuilders 1,431,795 1,425,977 -5,818 -0.41%
Sema.NumLazyIterableDeclContexts 9,596,296 9,571,349 -24,947 -0.26%
Sema.NumLazyRequirementSignatures 1,015,893 1,014,831 -1,062 -0.1%
Sema.NumLazyRequirementSignaturesLoaded 653,258 652,350 -908 -0.14%
Sema.NumLeafScopes 17,502,543 17,495,748 -6,795 -0.04%
Sema.NumTypesDeserialized 22,153,071 22,050,577 -102,494 -0.46%
Sema.NumTypesValidated 1,502,750 1,502,753 3 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 6,177,965 6,187,813 9,848 0.16%
Sema.OpaqueReadOwnershipRequest 281,180 281,180 0 0.0%
Sema.OpaqueResultTypeRequest 0 0 0 0.0%
Sema.OperatorPrecedenceGroupRequest 747 747 0 0.0%
Sema.OverriddenDeclsRequest 2,455,254 2,441,282 -13,972 -0.57%
Sema.ParamSpecifierRequest 1,288,703 1,288,696 -7 -0.0%
Sema.PatternBindingEntryRequest 462,269 462,279 10 0.0%
Sema.PreCheckFunctionBuilderRequest 0 0 0 0.0%
Sema.PropertyWrapperBackingPropertyInfoRequest 534,128 534,128 0 0.0%
Sema.PropertyWrapperBackingPropertyTypeRequest 539,465 539,465 0 0.0%
Sema.PropertyWrapperMutabilityRequest 630,451 630,451 0 0.0%
Sema.PropertyWrapperTypeInfoRequest 1 1 0 0.0%
Sema.ProtocolRequiresClassRequest 75,357 75,551 194 0.26%
Sema.RangeInfoRequest 0 0 0 0.0%
Sema.RequirementRequest 112,293 112,286 -7 -0.01%
Sema.RequirementSignatureRequest 731,721 730,998 -723 -0.1%
Sema.RequiresOpaqueAccessorsRequest 1,323,458 1,323,458 0 0.0%
Sema.RequiresOpaqueModifyCoroutineRequest 272,344 272,344 0 0.0%
Sema.ResilienceExpansionRequest 1,843,387 1,843,379 -8 -0.0%
Sema.ResolveImplicitMemberRequest 3,064,953 3,057,313 -7,640 -0.25%
Sema.ResolveProtocolNameRequest 0 0 0 0.0%
Sema.ResultTypeRequest 684,926 684,927 1 0.0%
Sema.RootAndResultTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.RootTypeOfKeypathDynamicMemberRequest 0 0 0 0.0%
Sema.SelfAccessKindRequest 897,913 897,781 -132 -0.01%
Sema.SelfBoundsFromWhereClauseRequest 7,871,118 7,836,214 -34,904 -0.44%
Sema.SetterAccessLevelRequest 145,065 145,065 0 0.0%
Sema.StorageImplInfoRequest 1,425,725 1,425,725 0 0.0%
Sema.StoredPropertiesAndMissingMembersRequest 32,222 32,222 0 0.0%
Sema.StoredPropertiesRequest 351,403 351,403 0 0.0%
Sema.StructuralTypeRequest 2,345 2,345 0 0.0%
Sema.SuperclassDeclRequest 493,458 492,735 -723 -0.15%
Sema.SuperclassTypeRequest 54,718 54,718 0 0.0%
Sema.SynthesizeAccessorRequest 294,500 294,500 0 0.0%
Sema.SynthesizeDefaultInitRequest 5,368 5,368 0 0.0%
Sema.SynthesizeMemberwiseInitRequest 3,167 3,167 0 0.0%
Sema.TypeCheckFunctionBodyUntilRequest 527,795 527,795 0 0.0%
Sema.TypeDeclsFromWhereClauseRequest 30,087 30,077 -10 -0.03%
Sema.TypeRelationCheckRequest 0 0 0 0.0%
Sema.TypeWitnessRequest 9,313 9,313 0 0.0%
Sema.UnderlyingTypeDeclsReferencedRequest 268,392 267,968 -424 -0.16%
Sema.UnderlyingTypeRequest 37,759 37,759 0 0.0%
Sema.ValueWitnessRequest 68,230 68,230 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (3)
name old new delta delta_pct
Frontend.NumInstructionsExecuted 49,622,877,373,177 49,605,487,680,299 -17,389,692,878 -0.04%
LLVM.NumLLVMBytesOutput 1,924,078,968 1,923,519,176 -559,792 -0.03%
time.swift-driver.wall 9214.2s 9199.2s -15.0s -0.16%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (18)
name old new delta delta_pct
AST.NumLoadedModules 29,851 29,851 0 0.0%
AST.NumTotalClangImportedEntities 1,207,348 1,207,348 0 0.0%
IRModule.NumIRBasicBlocks 5,465,917 5,465,917 0 0.0%
IRModule.NumIRFunctions 2,832,130 2,832,130 0 0.0%
IRModule.NumIRGlobals 3,151,672 3,152,036 364 0.01%
IRModule.NumIRInsts 53,020,354 53,020,354 0 0.0%
IRModule.NumIRValueSymbols 5,630,568 5,630,568 0 0.0%
LLVM.NumLLVMBytesOutput 1,924,078,968 1,923,519,176 -559,792 -0.03%
SILModule.NumSILGenFunctions 1,181,557 1,181,557 0 0.0%
SILModule.NumSILOptFunctions 1,685,574 1,685,574 0 0.0%
Sema.NumConformancesDeserialized 3,730,686 3,730,686 0 0.0%
Sema.NumConstraintScopes 26,616,203 26,616,203 0 0.0%
Sema.NumDeclsDeserialized 10,327,149 10,327,149 0 0.0%
Sema.NumFunctionsTypechecked 527,886 527,886 0 0.0%
Sema.NumGenericSignatureBuilders 278,176 278,176 0 0.0%
Sema.NumLazyIterableDeclContexts 1,309,105 1,309,105 0 0.0%
Sema.NumTypesDeserialized 5,171,771 5,171,771 0 0.0%
Sema.NumTypesValidated 817,852 817,852 0 0.0%
@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 19, 2019

@swift-ci please test

@brentdax brentdax requested a review from jckarter Nov 19, 2019
@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 19, 2019

Build failed
Swift Test Linux Platform
Git Sha - 8dc50eb

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 19, 2019

Build failed
Swift Test OS X Platform
Git Sha - 8dc50eb

@brentdax brentdax changed the title [Experiment] Make #file only include the filename Add command-line flag to shorten #file Nov 19, 2019
@brentdax brentdax marked this pull request as ready for review Nov 19, 2019
@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 19, 2019

@swift-ci please test

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 19, 2019

Build failed
Swift Test Linux Platform
Git Sha - c7ef675

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 19, 2019

Build failed
Swift Test OS X Platform
Git Sha - c7ef675

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 21, 2019

@swift-ci please smoke test

@brentdax brentdax force-pushed the brentdax:file-name-basis branch from aad3f02 to c3ab35b Nov 21, 2019
@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 21, 2019

@swift-ci please test

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 21, 2019

Build failed
Swift Test OS X Platform
Git Sha - c7ef675

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Nov 21, 2019

Build failed
Swift Test Linux Platform
Git Sha - c7ef675

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Nov 22, 2019

The test failure is because I need to re-gyb SwiftSyntax files.

@brentdax brentdax force-pushed the brentdax:file-name-basis branch from c3ab35b to d96ff67 Dec 3, 2019
brentdax added 2 commits Jun 21, 2019
This change may have significant code size benefits.
Along with a not-yet-usable way to get back to the old behavior.
brentdax added 4 commits Nov 16, 2019
This makes the path behavior more first-class. The feature is now hidden behind an experimental flag, -enable-experimental-concise-pound-file.
@brentdax brentdax force-pushed the brentdax:file-name-basis branch from d96ff67 to 63ec1cf Dec 5, 2019
@brentdax brentdax changed the title Add command-line flag to shorten #file Shorten #file and add #filePath (behind an experimental flag) Dec 5, 2019
@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Dec 5, 2019

@swift-ci

This comment was marked as off-topic.

Copy link
Contributor

swift-ci commented Dec 5, 2019

Build failed
Swift Test OS X Platform
Git Sha - c3ab35b

@swift-ci

This comment was marked as off-topic.

Copy link
Contributor

swift-ci commented Dec 5, 2019

Build failed
Swift Test Linux Platform
Git Sha - c3ab35b

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Dec 6, 2019

Copy link
Member

jckarter left a comment

LGTM.

@swift-ci

This comment has been minimized.

Copy link
Contributor

swift-ci commented Dec 6, 2019

Build failed
Swift Test OS X Platform
Git Sha - 63ec1cf

@brentdax

This comment has been minimized.

Copy link
Contributor Author

brentdax commented Dec 6, 2019

apple/swift-syntax#185

@swift-ci please clean test

@brentdax brentdax merged commit e1e7a3f into apple:master Dec 7, 2019
4 checks passed
4 checks passed
Swift Test Linux Platform
Details
Swift Test Linux Platform (smoke test)
Details
Swift Test OS X Platform
Details
Swift Test OS X Platform (smoke test)
Details
brentdax added a commit to apple/swift-syntax that referenced this pull request Dec 7, 2019
SwiftSyntax update for "Shorten #file and add #filePath (behind an experimental flag)" (apple/swift#25656)
compnerd added a commit to compnerd/apple-swift that referenced this pull request Dec 8, 2019
Be more lenient about the path separator.  This repairs the tests on
Windows after apple#25656.
compnerd added a commit to compnerd/apple-swift that referenced this pull request Dec 9, 2019
Be more lenient about the path separator.  This repairs the tests on
Windows after apple#25656.
compnerd added a commit to compnerd/apple-swift that referenced this pull request Dec 9, 2019
Be more lenient about the path separator.  This repairs the tests on
Windows after apple#25656.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.