[SR-2988][stdlib] Don't try to construct invalid UnicodeScalars
#5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inserting a closed range/creating a CharacterSet from a closed range we must not try to convert this range to a half open one by incrementing the upperBound UnicodeScalar because not all integer values are valid values for UnicodeScalar Fixes SR-2988
|
Ooh, good catch. I'm not a standard library reviewer, but I'll kick off tests for you: @swift-ci Please smoke test |
|
Thanks! @dabrahams mind taking a look? |
|
SInce this is a Foundation overlay change, I'm deferring to @parkera |
|
Looks good to me. Thanks @JaSpa. |
|
@swift-ci please test and merge |
parkera
added a commit
to parkera/swift-corelibs-foundation
that referenced
this pull request
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting a closed range/creating a
CharacterSetfrom a closed range we must not try to convert this range to a half open one by incrementing theupperBoundUnicodeScalarbecause not all integer values are valid values forUnicodeScalar.Resolves SR-2988.