Make emission of extension block symbols a formal feature #61637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add name to lib/Option/features.json - add flag for explicitly disabling extension block symbols feature
This was referenced Nov 12, 2022
|
LGTM! |
daniel-grumberg
approved these changes
Nov 24, 2022
|
@swift-ci please test |
|
Thanks for reviewing @daniel-grumberg! This can be merged now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #59047 and #61406.
This PR adds the
-omit-extension-block-symbolsflag for explicitly disabling the emission ofswift.extensionsymbols in symbol graph files. Furthermore, it adds the emission of extension block symbols to the feature listlib/Option/features.jsonas requested by @d-ronnqvist .The
-omit-extension-block-symbolshas no effect yet (except for overriding preceding-emit-extension-block-symbolsflags), as this PR does not change the default behavior.This PR finally fixes apple/swift-docc#210.
#61406 and apple/swift-driver#1205 should before/with this PR.