Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add riscv64 as supported architecture on linux #66530

Merged
merged 1 commit into from Jul 3, 2023
Merged

Add riscv64 as supported architecture on linux #66530

merged 1 commit into from Jul 3, 2023

Conversation

futurejones
Copy link
Contributor

Test Environment
OS = Ubuntu
Release = 22.04 / Jammy

When trying to build swift on a riscv64 linux system the following error occurs -

File "/home/build-user/swift/utils/swift_build_support/swift_build_support/targets.py", line 398, in host_target
    raise NotImplementedError('System "%s" with architecture "%s" is not '
NotImplementedError: System "Linux" with architecture "riscv64" is not supported

Resolves swift-riscv/swift-riscv64#1

@finagolfin
Copy link
Contributor

I think you'll need the changes in #61891 too.

@futurejones
Copy link
Contributor Author

@finagolfin yes, I am planning those changes and a number of others in future PR's.

@futurejones
Copy link
Contributor Author

@swift-ci please test

@futurejones
Copy link
Contributor Author

@shahmishal can you run the CI tests please?

@shahmishal
Copy link
Member

@swift-ci test

@shahmishal
Copy link
Member 

Failed Tests (1):
  Swift(iphonesimulator-x86_64) :: ModuleInterface/distributed_actors.swift

@bnbarham is this known issue?

@bnbarham
Copy link
Contributor

Yeah, I've disabled that test for now. It's brand new

@DougGregor
Copy link
Member

@swift-ci test macOS

@shahmishal shahmishal merged commit 80e4e04 into apple:main Jul 3, 2023
5 checks passed
@futurejones futurejones mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@finagolfin finagolfin finagolfin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Architecture "riscv64" is not supported
5 participants
@futurejones @finagolfin @shahmishal @bnbarham @DougGregor