[5.10][Macros] Diagnose attached and freestanding declaration macros that produce something other than a declaration. #69106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hborla
commented
Oct 10, 2023
hborla
commented
- Explanation: Attached and freestanding macros cannot expand to statements. However, the macro validation code was completely ignoring any ASTNode that isn't a declaration, allowing statement-producing macros to compile. Furthermore, for freestanding declaration macros, the experimental implementation of code item macros caused the invalid statements to be visited during SILGen, resulting in runtime crashes. This change diagnoses macro expansions that contain statements immediately after expansion.
- Scope: Only impacts freestanding and attached macros that allow parsing ASTNodes that are not declarations.
- Risk: Low.
- Testing: Added a new regression test.
- Reviewer: @DougGregor
- Main branch PR: [Macros] Diagnose attached and freestanding declaration macros that produce something other than a declaration. #69089
…roduce something other than a declaration. The validation code already diagnosed all sorts of invalid declarations, but it was ignoring AST nodes that aren't declarations at all. (cherry picked from commit 1f07cba)
|
@swift-ci please test |
airspeedswift
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.