AST: Targeted fix for conformance lookup issue [3.1] #7887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When substituting a type like T.A.B where A and B are associated types and the conformance requirement on T.A is implied by conformance requirements on T, we would crash. The problem is that we have no way of representing an abstract conformance with nested concrete types. This patch adds a workaround. Fixes <rdar://problem/30737546> and <https://bugs.swift.org/browse/SR-3500>.
|
@DougGregor I'd like to put something like this into 3.1 since lookupConformance() is even more broken there than on master. |
slavapestov
changed the title
|
@swift-ci Please test |
DougGregor
approved these changes
Mar 3, 2017
kvfi
approved these changes
Mar 3, 2017
|
The test I'm adding here is already on master. |
This was referenced Mar 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When substituting a type like T.A.B where A and B are
associated types and the conformance requirement on T.A
is implied by conformance requirements on T, we would
crash.
The problem is that we have no way of representing an
abstract conformance with nested concrete types.
This patch adds a workaround.
Fixes rdar://problem/30737546,
https://bugs.swift.org/browse/SR-3500 and https://bugs.swift.org/browse/SR-4088.
I'm going to keep 3500 open to track fixing the issue on master, but close the other dupes of this.