Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

AC utility function random_split_by_session should call the C++ impl #2678

Open
shreyajain17 opened this issue Nov 19, 2019 · 3 comments
Open

Comments

@shreyajain17
Copy link
Collaborator

shreyajain17 commented Nov 19, 2019

The utility random_split_by_session function provided to users should also call the Cpp implementation of it instead of the logic in python.

@TobyRoseman
Copy link
Collaborator

@shreyajain17 - can you link to the Cpp implementation which should be used?

@TobyRoseman TobyRoseman added this to the 6.2 milestone Jan 31, 2020
@shreyajain17
Copy link
Collaborator Author

std::tuple<gl_sframe, gl_sframe> activity_classifier::random_split_by_session(

@TobyRoseman
Copy link
Collaborator

Both of these functions take a seed parameter and they use the seed parameter in different ways. If we make this change the same user code will produce different results. So this is going to be an API breaking change. I'm going to remove this from the current milestone.

@TobyRoseman TobyRoseman removed this from the 6.2 milestone Apr 1, 2020
@TobyRoseman TobyRoseman added this to the 6.3 milestone Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants