Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Style Transfer stylize does no parameter checking #2790

Closed
TobyRoseman opened this issue Dec 4, 2019 · 1 comment
Closed

Style Transfer stylize does no parameter checking #2790

TobyRoseman opened this issue Dec 4, 2019 · 1 comment
Assignees
@TobyRoseman
Labels
bug style transfer toolkits
Milestone
6.1

Comments

@TobyRoseman
Copy link
Collaborator

The stylize method should do basic parameter checking. It should check that images and style are of supported types. Also that max_size and batch_size are greater than zero. Probably additonal checks also make sense.

Currently it's possible for unsupported values to silently fall thru. The following returns None without error: model.stylize('junk value', style=-1)
@TobyRoseman TobyRoseman added this to the 6.1 milestone Dec 10, 2019
@TobyRoseman TobyRoseman self-assigned this Dec 16, 2019
@TobyRoseman TobyRoseman mentioned this issue Dec 16, 2019
Merged
@TobyRoseman
Copy link
Collaborator Author

Fixed by #2864

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TobyRoseman TobyRoseman

Labels
bug style transfer toolkits
Projects
None yet
Milestone
6.1
Development

No branches or pull requests
1 participant
@TobyRoseman