Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSK is allowed in link files and assembly files #35

Closed
ksherlock opened this issue Dec 25, 2019 · 4 comments
Closed

DSK is allowed in link files and assembly files #35

ksherlock opened this issue Dec 25, 2019 · 4 comments

Comments

@ksherlock
Copy link

char *opcode_link[] = {"DSK","TYP","AUX","XPL","ASM","DS","KND","ALI","LNA","SNA","ORG","BSZ",NULL}; /* Opcode exclusifs au File Link */

^^^
causes assembly files with a DSK opcode to (incorrectly) be treated as a link file, with predictable results.

@digarok
Copy link
Contributor

digarok commented Feb 10, 2020

Assuming the following code in a file called test.s:

 org $2000
 dsk myapp
 sta $ff

Previously (Brutal Deluxe) builds of Merlin would assemble that fine and create a 2-byte file called "myapp".

Now I'm getting the following error as though it's trying to treat it as a link file:

$ ~/appleiigs/tools/merlin32 test.s
/Users/dbrock/appleiigs/tools/merlin32 v1.1.8, (c) Brutal Deluxe 2011-2015
  + Loading Link file...
     => Error, Invalid Link file : Unknown (or misordered) directive found (org) at line 1.
      => [Error] Impossible to load Link file 'test.s'. 

@digarok
Copy link
Contributor

digarok commented Feb 10, 2020

Also, TYP is valid for assembly file as well.

@fadden
Copy link

fadden commented Mar 19, 2020

I'm seeing the same thing -- simple programs with ORG statements will not assemble.

@gungwald
Copy link
Member

This bug was fixed by this commit lroathe@307813e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants