Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when adding files to a disk image that is or was full #58

Closed
ryandesign opened this issue Sep 24, 2021 · 2 comments
Closed

Crash when adding files to a disk image that is or was full #58

ryandesign opened this issue Sep 24, 2021 · 2 comments

Comments

@ryandesign
Copy link

Using the AppleCommander 1.6.0 GUI on macOS 10.13.6 I created a DOS 3.3 DOS order disk image.

If I try to add files to the disk image that will occupy more space than is available on the disk image, AppleCommander quits immediately when I press the Finish button in the Import dialog. It should instead tell me the disk is out of space and remain open so that I can correct the problem.

If I delete existing files on the disk and then try to add a new file, it quits just the same, even though there should now be enough space. It should instead add the files to the disk and not quit.

@a2geek
Copy link
Contributor

a2geek commented Jan 9, 2022

This will be fixed with the next version of AppleCommander. Good find! As far as I can determine, it's been there for more than a decade at this point! The issue was with the text lookups -- the keys didn't exist, and, they had simply been entered incorrectly. I did change the error message to at least identify what was missing for any future items as well. (If it happened once, I'm certain it's happened a couple of others as well.)

@a2geek a2geek added the bug label Jan 9, 2022
@a2geek
Copy link
Contributor

a2geek commented Jan 9, 2022

I forgot to add the ticket number. This is the commit: 366c921

@a2geek a2geek added this to Ready in AppleCommander 1.7.0 Jan 10, 2022
@a2geek a2geek moved this from Ready to Done in AppleCommander 1.7.0 Jan 21, 2022
@a2geek a2geek closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants