Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove/destroy ModalVideo on smaller screen size #25

Open
DaneSuen opened this issue Jul 31, 2018 · 4 comments · May be fixed by #94
Open

remove/destroy ModalVideo on smaller screen size #25

DaneSuen opened this issue Jul 31, 2018 · 4 comments · May be fixed by #94
Assignees

Comments

@DaneSuen
Copy link

I like the function from Magnific Popup that the button acts as a link instead of a modal toggle when open/resize page to a small screen. Ideally, on mobile devices, when users click the video link, I'd prefer them to open and see it in their YouTube app, instead of a small popup on the page. I'm thinking either

  1. tweak the plugin function to detect screen size, and make the link acts differently. OR
  2. add my own function to listen to resize event, and destroy/re-add the ModalVideo when screen reach a brekapoint.
    I'm leaning towards the latter for now, and wonder if there's a way to destroy ModalVideo instances in the current plugin?
    Thanks.
@ayafaheem
Copy link

Hello Dear
Is there a way to destroy ModalVideo ?
to re add it again ?

@steelydylan
Copy link
Contributor

@ayafaheem for now there are no option to destroy and readd ModalVideo
I'll think about it !

@DjuriSchiffer
Copy link

@steelydylan Any update about this option?

@uidev1116
Copy link

@DaneSuen
Sorry for late reply.

I am considering destroy method.

@1000-x-t30 1000-x-t30 linked a pull request Jun 29, 2023 that will close this issue
@1000-x-t30 1000-x-t30 linked a pull request Sep 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants