New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XXH3_64 implementation gives incompatible hash values for short input lengths #42

Closed

oertl opened this issue May 26, 2022 · 1 comment · Fixed by #43

oertl commented May 26, 2022

Some short inputs with 1,2, or 3 bytes lead to different hash values compared to the native reference implementation from https://github.com/Cyan4973/xxHash. The behavior can be reproduced with this unit test https://github.com/dynatrace-oss/hash4j/blob/01e8ed429c61acd7735967b2ba472c80d4616337/src/test/java/com/dynatrace/hash4j/hashing/CrossCheckTest.java#L195 which checks the compatibility with the reference implementation.

mattmook mentioned this issue

Fix bug in XXH3 64bit implementation and add more complete tests #43

Merged

mattmook closed this as completed in #43

Member

mattmook commented Jun 15, 2022

Thanks @oertl for the bug report. Version 0.10.1 is being released with the bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment