cacheObject with fields using customized cache IDs not updating

[jsindos]

It seems like apollo-augmented-hooks/useMutation isn't able to update a cacheObject with fields who have customized cache IDs. In this case, ProductInBag has a custom cache ID derived from selectedOption.id, it's not removed from bag when using includeIf(false).

type Bag {
    id: Int
    products: [ProductInBag]
}
...
new InMemoryCache({
    typePolicies: {
      ProductInBag: {
        keyFields: ['selectedOption', ['id']]
      }
  }
})
...
const DELETE_PRODUCT_FROM_BAG = gql`
  mutation DeleteProductFromBag($selectedOptionId: Int!) {
    deleteProductFromBag(selectedOptionId: $selectedOptionId) {
      selectedOption {
        id
      }
    }
  }
`
...
const deleteProductFromBagMutation = useMutation(DELETE_PRODUCT_FROM_BAG)

const handleOnPressDelete = async (selectedOption) => {
  await deleteProductFromBagMutation({
    variables: {
      selectedOptionId: selectedOption.id
    },
    modifiers: [{
      cacheObject: bag,
      fields: {
        products: ({ includeIf }) => includeIf(false) // this is not removing the deleted ProductInBag, even though it is returned from mutation
      }
    }]
  })
}

[jsindos]

The following from Apollo works

const handleOnPressDelete = async (selectedOption) => {
  await deleteProductFromBagMutation({
    variables: {
      selectedOptionId: selectedOption.id
    },
    update: (cache, mutationResult) => {
      cache.modify({
        id: `${bag.__typename}:${bag.id}`,
        fields: {
          products: (previous, { readField }) =>
            previous.filter(
              productInBagRef => selectedOption.id !== readField('selectedOption', productInBagRef).id
            )
        }
      })
    }
  })
}

I assume the fix would involve detecting when a ref has a customised cache ID, and using

ref => idToRemove !== readField('customisedCacheId', ref).anyNestedCustomisedCacheId

instead of

ref => idToRemove !== readField('id', ref)

as the filter function.

[mindnektar]

Hey there, thanks for the heads up! apollo-augmented-hooks already works with custom keys (I'm using them extensively in my projects as well), but what might not work is nested keys (['selectedOption', ['id']]). I don't remember having used those before. I will check that out and report back later today.

[mindnektar]

@jsindos I've fixed the issue in v2.1.1 - please see if it works for you. :)

[jsindos]

@mindnektar that works, thanks for fixing it so quickly :)