Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for snapshot existence before delete #548

Merged
merged 2 commits into from Aug 15, 2018
Merged

Check for snapshot existence before delete #548

merged 2 commits into from Aug 15, 2018

Conversation

hossainemruz
Copy link
Contributor

@hossainemruz hossainemruz commented Aug 8, 2018

This PR fixes #549
Task list:

  • Check if snapshot exist before delete
  • Used k8s.io/apimachinery/pkg/api/errors

@codecov-io
Copy link

codecov-io commented Aug 8, 2018

Codecov Report

Merging #548 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #548   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines           7      7           
=====================================
  Hits            7      7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb3bbf...28a3ccd. Read the comment docs.

@hossainemruz hossainemruz changed the title WIP: Use namespace in repository prefix Check for snapshot existence before delete Aug 9, 2018
@@ -14,7 +14,7 @@ source "$REPO_ROOT/hack/libbuild/common/public_image.sh"

APPSCODE_ENV=${APPSCODE_ENV:-dev}
IMG=stash
RESTIC_VER=${RESTIC_VER:-0.9.1}
RESTIC_VER=${RESTIC_VER:-0.8.3}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts back to 0.8.3 because of restic/restic#1934

@tamalsaha tamalsaha merged commit 7a7145d into master Aug 15, 2018
@tamalsaha tamalsaha deleted the fix-recovery branch August 15, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete snapshot command does not check for snapshot's existence
3 participants