Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument Rack middleware #159

Closed
thijsc opened this issue Sep 19, 2016 · 7 comments
Closed

Instrument Rack middleware #159

thijsc opened this issue Sep 19, 2016 · 7 comments

Comments

@thijsc
Copy link
Member

thijsc commented Sep 19, 2016

If there are Rack middlewares running before your requests we should instrument these so you can see how they influence performance.

Requests

@tombruijn
Copy link
Member

If at all possible, find a way to track errors inside ActionDispatch::ShowExceptions and ActionDispatch::DebugExceptions, even if they're kind of private errors. Namely ActionController::RoutingError for routing errors and non existing routes

As suggested here:
https://app.intercom.io/a/apps/yzor8gyw/inbox/conversation/6039076300?nsrc=slack

@tombruijn
Copy link
Member

Review how we would want to do this in combination with #329
Timeboxed research about methods we can do this with one or more middlewares and potential rack monkey patches.

@tombruijn
Copy link
Member

@tombruijn tombruijn changed the title Instrument Rack middleware 🚀 Instrument Rack middleware Oct 27, 2017
@tombruijn
Copy link
Member

  • start only one transaction per request. If another transaction is active, don't start a new one.
  • HAve the middleware complete their own transaction? Rather than Appsignal::Transaction.complete_current!

@tombruijn tombruijn changed the title 🚀 Instrument Rack middleware Instrument Rack middleware May 15, 2018
@tombruijn
Copy link
Member

Related issue: #329

@tombruijn
Copy link
Member

Closing in favor of #329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants