Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set icon for Mbaza that works in all places #41

Closed
2 tasks
tadeuszbaraslupski opened this issue Mar 27, 2020 · 0 comments · Fixed by #60
Closed
2 tasks

Set icon for Mbaza that works in all places #41

tadeuszbaraslupski opened this issue Mar 27, 2020 · 0 comments · Fixed by #60
Assignees
Projects

Comments

@tadeuszbaraslupski
Copy link

tadeuszbaraslupski commented Mar 27, 2020

Acceptance criteria

  • new icon is displayed in the app, on the desktop shortcuts, in system bar
  • works at least on Windows and Linux, and ideally also on Mac (paste screenshots to streamline code review)

More info

Documentation is here, but I think it's not exact https://www.electron.build/icons. Instead you may need to add all files as in the resources folder in https://github.com/electron-react-boilerplate/electron-react-boilerplate/tree/master/resources (I deleted most of them at some point because from the docs it seemed they were not necessary)

Final design approved by Robbie below.

JPG: https://drive.google.com/open?id=15e-1JaNTV89qiE2qwpp-oXbknief4Qtv
SVG: https://drive.google.com/file/d/1dS5pEkiijpPOzpuBtHzp94Z60UnstJ4U/view?usp=sharing

@marekrogala marekrogala added this to To do in MVP May 8, 2020
@marekrogala marekrogala changed the title Set icon for Mbaza Set icon for Mbaza that works in all places May 12, 2020
@marekrogala marekrogala moved this from To do to In progress in MVP Jun 8, 2020
@marekrogala marekrogala mentioned this issue Jun 8, 2020
MVP automation moved this from In progress to Done Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
MVP
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants