Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite addon to rust/gdext #86

Closed
Ughuuu opened this issue Apr 28, 2024 · 2 comments · Fixed by #84
Closed

Rewrite addon to rust/gdext #86

Ughuuu opened this issue Apr 28, 2024 · 2 comments · Fixed by #84
Assignees
Labels
enhancement New feature or request

Comments

@Ughuuu
Copy link
Contributor

Ughuuu commented Apr 28, 2024

As of now, the addon has parts in c++ and a wrapper in rust.
Because of this, it's hard to make web builds work (because of the first wrapper in rust, it needs some js hacks to work).
GDext(godot-rust) extension somehow figured it out. It might be difficult to do here.
Also, cross platform determinism is way easier to do in rust than in c++.

That being said, I think it would be most beneficial to have all the code written in rust, and not have 2 layers of code(c++ and rust).

@Ughuuu Ughuuu added the bug Something isn't working label Apr 28, 2024
@Ughuuu Ughuuu self-assigned this Apr 28, 2024
@Ughuuu Ughuuu added enhancement New feature or request and removed bug Something isn't working labels Apr 28, 2024
@Ughuuu Ughuuu mentioned this issue Apr 28, 2024
@Ughuuu
Copy link
Contributor Author

Ughuuu commented May 3, 2024

Initial draft(1 to 1 transcribe). After this a test phase should happen.

Progress:

  • Bodies: Rapier Area
  • Bodies: Rapier Body
  • Bodies: Rapier Collision Object
  • Bodies: Rapier Direct Body Space
  • Fluids: Fluid Effect
  • Fluids: Rapier Fluid
  • Joints: Rapier Damped Spring Joint
  • Joints: Rapier Groove Joint
  • Joints: Rapier Joint
  • Joints: Rapier Pin Joint
  • Rapier2D: Wrapper
  • Servers: Body Utils
  • Servers: Rapier Physics Server
  • Servers: Rapier Project Settings
  • Servers: Rapier Physics Singleton
  • Shapes: Rapier Capsule Shape
  • Shapes: Rapier Circle Shape
  • Shapes: Rapier Concave Polygon Shape
  • Shapes: Rapier Convex Polygon Shape
  • Shapes: Rapier Rectangle Shape
  • Shapes: Rapier Segment Shape
  • Shapes: Rapier Separation Ray Shape
  • Shapes: Rapier World Boundary Shape
  • Shapes: Rapier Shape
  • Spaces: Rapier Direct Space State
  • Spaces: Rapier Space

@Ughuuu Ughuuu pinned this issue May 3, 2024
@Ughuuu Ughuuu changed the title Rewrite addon to rust Rewrite addon to rust/gdext May 3, 2024
@Ughuuu
Copy link
Contributor Author

Ughuuu commented Jun 13, 2024

Functionality implementation is done, now the tests have to pass:

  • 44/44: Rigidbody
  • 1/2: CollisionShape
  • 5/5: Raycast
  • 47/48: DirectSpaceState
  • 18/20: CharacterBody
  • 18/21: Area
  • 4/10: Moving Platforms

  • 137/150: Total tests

@Ughuuu Ughuuu closed this as completed in 734aac0 Jun 18, 2024
@Ughuuu Ughuuu unpinned this issue Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant